[Mac] Make app window backgrounds white.

chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h"
 
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "base/command_line.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
@@ skipping 199 matching lines @@
 @interface ShellNSWindow : ChromeEventProcessingWindow
 @end
 @implementation ShellNSWindow
 
 // Similar to ChromeBrowserWindow, don't draw the title, but allow it to be seen
 // in menus, Expose, etc.
 - (BOOL)_isTitleHidden {
   return YES;
 }
 
+- (void)drawCustomFrameRect:(NSRect)rect forView:(NSView*)view {
+  // Make the background color of the content area white. We can't just call
+  // -setBackgroundColor as that causes the title bar to be drawn in a solid
+  // color.
+  NSRect contentRect = [NSWindow contentRectForFrameRect:rect

[tapted, 2014/06/17 06:09:51]

I think you can use [self contentRectForFrameRect:rect];

[jackhou1, 2014/06/17 07:00:14]

Done.

+                                               styleMask:[self styleMask]];
+  [[NSColor whiteColor] set];
+  NSRectFill(contentRect);
+
+  // Draw the native title bar. We clip the content area since the native
+  // implementation draws a grey background.

[tapted, 2014/06/17 06:09:52]

nit: grey -> gray to be consistent with color :p

[jackhou1, 2014/06/17 07:00:14]

Done.

+  NSRect titleBarRect = NSIntersectionRect(rect,
+                                           NSMakeRect(NSMinX(contentRect),

[tapted, 2014/06/17 06:09:51]

I stared at the second argument for a while before realising what it was doing
(I was reading NSMaxY as NSMinY). Pity there's no NSSubtractRect (I think).

Maybe rename:
 rect -> frameRect
 contentRect -> rect

Then do

rect.origin.y = NSMaxY(rect);
rect.size.height = CGFLOAT_MAX;
rect = NSIntersectionRect(rect, frameRect);


I think this makes it clearer what's changing.

[jackhou1, 2014/06/17 07:00:14]

Done.

+                                                      NSMaxY(contentRect),
+                                                      NSWidth(contentRect),
+                                                      CGFLOAT_MAX));
+  [NSBezierPath clipRect:titleBarRect];

[tapted, 2014/06/17 06:09:52]

It's possible clipping will be more expensive than just painting the full area
twice (assuming that actually works) (but I'm guessing, so probably not worth
worrying about)

+  [super drawCustomFrameRect:rect
+                     forView:view];
+}
+
 @end
 
 @interface ShellCustomFrameNSWindow : ShellNSWindow {
  @private
   base::scoped_nsobject<NSColor> color_;
   base::scoped_nsobject<NSColor> inactiveColor_;
 }
 
 - (void)setColor:(NSColor*)color
     inactiveColor:(NSColor*)inactiveColor;
@@ skipping 733 matching lines @@
 }
 
 void NativeAppWindowCocoa::UpdateRestoredBounds() {
   if (IsRestored(*this))
     restored_bounds_ = [window() frame];
 }
 
 void NativeAppWindowCocoa::HideWithoutMarkingHidden() {
   [window() orderOut:window_controller_];
 }