[Mac] Make app window backgrounds white.

chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h"
 
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "base/command_line.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
@@ skipping 199 matching lines @@
 @interface ShellNSWindow : ChromeEventProcessingWindow
 @end
 @implementation ShellNSWindow
 
 // Similar to ChromeBrowserWindow, don't draw the title, but allow it to be seen
 // in menus, Expose, etc.
 - (BOOL)_isTitleHidden {
   return YES;
 }
 
+- (void)drawCustomFrameRect:(NSRect)rect forView:(NSView*)view {
+  [super drawCustomFrameRect:rect
+                     forView:view];
+
+  // Make the background color of the content area white.
+  NSRect contentRect = [NSWindow contentRectForFrameRect:rect
+                                               styleMask:[self styleMask]];
+  [[NSBezierPath bezierPathWithRect:contentRect] addClip];
+  [[NSColor whiteColor] set];
+  NSRectFill(rect);
+}
+
 @end
 
 @interface ShellCustomFrameNSWindow : ShellNSWindow {
  @private
   base::scoped_nsobject<NSColor> color_;
   base::scoped_nsobject<NSColor> inactiveColor_;
 }
 
 - (void)setColor:(NSColor*)color
     inactiveColor:(NSColor*)inactiveColor;
@@ skipping 103 matching lines @@
 
   // Estimate the initial bounds of the window. Once the frame insets are known,
   // the window bounds and constraints can be set precisely.
   NSRect cocoa_bounds = GfxToCocoaBounds(
       params.GetInitialWindowBounds(gfx::Insets()));
   window.reset([[window_class alloc]
       initWithContentRect:cocoa_bounds
                 styleMask:GetWindowStyleMask()
                   backing:NSBackingStoreBuffered
                     defer:NO]);
 

[tapted, 2014/06/17 00:21:53]

would it make sense to just call [window setBackgroundColor:[NSColor
whiteColor]] here?

[jackhou1, 2014/06/17 00:37:15]

That seems to make the entire background white (including the title bar).

[tapted, 2014/06/17 06:09:51]

Ah - yeah that would suck.

   std::string name;
   const extensions::Extension* extension = app_window_->GetExtension();
   if (extension)
     name = extension->name();
   [window setTitle:base::SysUTF8ToNSString(name)];
   [[window contentView] cr_setWantsLayer:YES];
   if (has_frame_ && has_frame_color_) {
     [base::mac::ObjCCastStrict<ShellCustomFrameNSWindow>(window)
              setColor:gfx::SkColorToSRGBNSColor(active_frame_color_)
         inactiveColor:gfx::SkColorToSRGBNSColor(inactive_frame_color_)];
@@ skipping 609 matching lines @@
 }
 
 void NativeAppWindowCocoa::UpdateRestoredBounds() {
   if (IsRestored(*this))
     restored_bounds_ = [window() frame];
 }
 
 void NativeAppWindowCocoa::HideWithoutMarkingHidden() {
   [window() orderOut:window_controller_];
 }