Issue 338753002: Revert of Revert: Per navigation sticky media permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338753002: Revert of Revert: Per navigation sticky media permissions. (Closed)

Created:
6 years, 6 months ago by henrika (OOO until Aug 14)

Modified:
6 years, 6 months ago

Reviewers:
no longer working on chromium, tommi (sloooow) - chröme

CC:
chromium-reviews, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Revert: Per navigation sticky media permissions. (https://codereview.chromium.org/336653002/) Reason for revert: THis CL breaks several WebRTC bots. See e.g. http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester. [32/32] WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 (TIMED OUT) 2 tests timed out: WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/0 WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 Original issue's description: > Revert: Per navigation sticky media permissions. > This CL re-enables the same behavior for getUserMedia prompts as it was in M35. > The reason for this is because there was a change of hearts at the standards level about this. > More information in the issue. > > BUG=269719 > COLLABORATOR=xians > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276974 TBR=xians@chromium.org,tommi@chromium.org NOTREECHECKS=true NOTRY=true BUG=269719 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277377

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -2 lines)			Patch
	M	chrome/browser/media/chrome_media_stream_infobar_browsertest.cc	View		2 chunks	+51 lines, -2 lines	0 comments	Download
	M	chrome/browser/media/media_stream_devices_controller.cc	View		6 chunks	+111 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

henrika (OOO until Aug 14)

Created Revert of Revert: Per navigation sticky media permissions.

6 years, 6 months ago (2014-06-16 07:40:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/338753002/1

6 years, 6 months ago (2014-06-16 07:41:08 UTC) #2

Message was sent while issue was closed.

Change committed as 277377