Chromium Code Reviews

Issue 338733002: Files.app: Add new owners to the ui/file_manager directory and its tests. (Closed)

Created:
6 years, 6 months ago by hirono
Modified:
6 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, fukino
Project:
chromium
Visibility:
Public.

Description

Files.app: Add new owners to the ui/file_manager directory and its tests. BUG=None TEST=None R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277365

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Remove @hidehiko from OWNERS. #

Unified diffs Side-by-side diffs Stats (+3 lines, -1 line)
M chrome/browser/chromeos/file_manager/OWNERS View 1 chunk +2 lines, -1 line 0 comments
M ui/file_manager/OWNERS View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 4 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 6 months ago (2014-06-16 04:02:10 UTC) #1
kinaba
lgtm. cc: fukino https://codereview.chromium.org/338733002/diff/20001/chrome/browser/chromeos/file_manager/OWNERS File chrome/browser/chromeos/file_manager/OWNERS (right): https://codereview.chromium.org/338733002/diff/20001/chrome/browser/chromeos/file_manager/OWNERS#newcode2 chrome/browser/chromeos/file_manager/OWNERS:2: hidehiko@chromium.org Could you remove hidehiko from ...
6 years, 6 months ago (2014-06-16 04:22:34 UTC) #2
hirono
Thank you! https://codereview.chromium.org/338733002/diff/20001/chrome/browser/chromeos/file_manager/OWNERS File chrome/browser/chromeos/file_manager/OWNERS (right): https://codereview.chromium.org/338733002/diff/20001/chrome/browser/chromeos/file_manager/OWNERS#newcode2 chrome/browser/chromeos/file_manager/OWNERS:2: hidehiko@chromium.org On 2014/06/16 04:22:34, kinaba wrote: > ...
6 years, 6 months ago (2014-06-16 06:47:18 UTC) #3
hirono
6 years, 6 months ago (2014-06-16 07:13:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r277365 (presubmit successful).

Powered by Google App Engine