Add probe to warm data reduction proxy

components/data_reduction_proxy/browser/data_reduction_proxy_settings.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_SETTINGS_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_SETTINGS_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 155 matching lines @@
   // Returns an vector containing the aggregate received HTTP content in the
   // last |kNumDaysInHistory| days.
   ContentLengthList GetDailyReceivedContentLengths();
 
   // net::URLFetcherDelegate:
   virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
 
  protected:
   void InitPrefMembers();
 
+  // Returns a fetcher for the probe to check if OK to use SPDY.

[marq (ping after 24h), 2014/06/16 17:23:35]

This probe checks for carrier blocking, right? Not SPDY.

Should this be GetURLFetcherForAvailabiliyCheck() or something?

Add a note that the difference between this fetcher and the proxy-warmup fetcher
is that this one is flagged to bypass proxy settings.

Add a note that these methods are virtualized for testing.

[bengr, 2014/06/17 03:42:09]

We've considered reasons other than carrier blocking to disallow SPDY, so I left
the comment more or less as is, but added the note about it being virtual for
testing. I changed the name of the function.

   virtual net::URLFetcher* GetURLFetcher();
 
+  // Returns a fetcher to warm up the connection to the data reduction proxy.
+  virtual net::URLFetcher* GetURLFetcherForWarmup();
+
   // Virtualized for unit test support.
   virtual PrefService* GetOriginalProfilePrefs();
   virtual PrefService* GetLocalStatePrefs();
 
   void GetContentLengths(unsigned int days,
                          int64* original_content_length,
                          int64* received_content_length,
                          int64* last_update_time);
   ContentLengthList GetDailyContentLengths(const char* pref_name);
 
@@ skipping 78 matching lines @@
 
   void ResetDataReductionStatistics();
 
   void MaybeActivateDataReductionProxy(bool at_startup);
 
   // Requests the proxy probe URL, if one is set.  If unable to do so, disables
   // the proxy, if enabled. Otherwise enables the proxy if disabled by a probe
   // failure.
   void ProbeWhetherDataReductionProxyIsAvailable();
 
+  // Warms the connection to the data reduction proxy.
+  void WarmProxyConnection();
+
+  // Generic method to get a URL fetcher.
+  net::URLFetcher* GetBaseURLFetcher(const GURL& gurl, int load_flags);
+
   // Returns a UTF16 string that's the hash of the configured authentication
   // |key| and |salt|. Returns an empty UTF16 string if no key is configured or
   // the data reduction proxy feature isn't available.
   static base::string16 AuthHashForSalt(int64 salt,
                                         const std::string& key);
 
   std::string key_;
   bool restricted_by_carrier_;
   bool enabled_by_user_;
 
   scoped_ptr<net::URLFetcher> fetcher_;

[marq (ping after 24h), 2014/06/16 17:23:35]

Rename to (e.g.) availabilty_check_fetcher_

+  scoped_ptr<net::URLFetcher> warmup_fetcher_;
+
   BooleanPrefMember spdy_proxy_auth_enabled_;
   BooleanPrefMember data_reduction_proxy_alternative_enabled_;
 
   PrefService* prefs_;
   PrefService* local_state_prefs_;
 
   net::URLRequestContextGetter* url_request_context_getter_;
 
   scoped_ptr<DataReductionProxyConfigurator> configurator_;
 
   base::ThreadChecker thread_checker_;
 
   scoped_ptr<DataReductionProxyParams> params_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxySettings);
 };
 
 }  // namespace data_reduction_proxy
 
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_SETTINGS_H_