Remove duplicated provideMediaKeysTo() in MediaKeysClient.h

Remove duplicated provideMediaKeysTo() in MediaKeysClient.h

Though MediaKeysController has already provideMediaKeysTo() which is being used by WebViewImpl, MediaKeysClient.h also has provideMediaKeysTo() unnecessary.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177184

[gyuyoung-inactive, 2014-06-15 14:49:01]

Add jochen

[pdr., 2014-06-15 18:14:15]

On 2014/06/15 14:49:01, gyuyoung wrote:
> Add jochen

What is the purpose of this change? Please include it in your change
description.

[gyuyoung-inactive, 2014-06-16 00:36:45]

On 2014/06/15 18:14:15, pdr wrote:
> On 2014/06/15 14:49:01, gyuyoung wrote:
> > Add jochen
> 
> What is the purpose of this change? Please include it in your change
> description.

pdr, this cl is minor code refactoring so that we can reduce to keep unnecessary
member variable and header file inclusion. Though this cl is not big helpful
change, I believe this helps to clean up code.

[abarth-chromium, 2014-06-16 04:46:20]

not lgtm

This CL creates a memory leak.  The created object is never freed.

[gyuyoung-inactive, 2014-06-16 07:40:23]

On 2014/06/16 04:46:20, abarth wrote:
> not lgtm
> 
> This CL creates a memory leak.  The created object is never freed.

Oops. I'm sorry. I modify this cl as latest one. Though this is minor
refactoring, I think it would be better if MediaKeysController manages
MediaKeysClient object.

[acolwell GONE FROM CHROMIUM, 2014-06-16 15:18:34]

+ddorwin & +jrummell since they are actively working on this code and need to be
kept in the loop.

gyuyoung, please make sure to include them as reviewers in future changes to the
EME code since they are the owners for that module.

[gyuyoung-inactive, 2014-06-17 01:25:53]

On 2014/06/16 15:18:34, acolwell wrote:
> +ddorwin & +jrummell since they are actively working on this code and need to
be
> kept in the loop.
> 
> gyuyoung, please make sure to include them as reviewers in future changes to
the
> EME code since they are the owners for that module.

ok, I see. Anyway, abarth, what do you think about latest patch ?

[abarth-chromium, 2014-06-17 05:09:01]

On 2014/06/17 at 01:25:53, gyuyoung.kim wrote:
> ok, I see. Anyway, abarth, what do you think about latest patch ?

This CL doesn't appear to solve a real problem.  You've removed one pointer on
WebViewImpl and replaced it with a startup malloc.  It's not clear that trade is
worth making.

[gyuyoung-inactive, 2014-06-23 06:33:07]

https://codereview.chromium.org/338713002/diff/40001/Source/web/WebViewImpl.h
File Source/web/WebViewImpl.h (left):

https://codereview.chromium.org/338713002/diff/40001/Source/web/WebViewImpl.h...
Source/web/WebViewImpl.h:694: MediaKeysClientImpl m_mediaKeysClientImpl;
m_mediaKeysClientImpl instance is only used by MediaKeyController. So, I thought
that it would be good to move ownership to MediaKeyController. However, I agree
that this is not big worth to do because this is trivial refactoring. To be
honest, I don't understand where memory leak happens in my last patch. Last one
is to pass OwnPtr to MediaKeyController's member variable, then it will be free
when going out of MediaKeyController. Anyway, now I just would like to remove
unused provideMediaKeysTo() in MediaKeyClient.h. Because MediaKeyController has
already same function and it is only being used by WebViewImpl.cpp. It looks the
function is duplicated.

[gyuyoung-inactive, 2014-06-24 22:15:23]

On 2014/06/23 06:33:07, gyuyoung wrote:
> https://codereview.chromium.org/338713002/diff/40001/Source/web/WebViewImpl.h
> File Source/web/WebViewImpl.h (left):
> 
>
https://codereview.chromium.org/338713002/diff/40001/Source/web/WebViewImpl.h...
> Source/web/WebViewImpl.h:694: MediaKeysClientImpl m_mediaKeysClientImpl;
> m_mediaKeysClientImpl instance is only used by MediaKeyController. So, I
thought
> that it would be good to move ownership to MediaKeyController. However, I
agree
> that this is not big worth to do because this is trivial refactoring. To be
> honest, I don't understand where memory leak happens in my last patch. Last
one
> is to pass OwnPtr to MediaKeyController's member variable, then it will be
free
> when going out of MediaKeyController. Anyway, now I just would like to remove
> unused provideMediaKeysTo() in MediaKeyClient.h. Because MediaKeyController
has
> already same function and it is only being used by WebViewImpl.cpp. It looks
the
> function is duplicated.

Abarth, could you take a look this cl again ?

[gyuyoung-inactive, 2014-06-30 02:20:35]

On 2014/06/24 22:15:23, gyuyoung wrote:
> On 2014/06/23 06:33:07, gyuyoung wrote:
> >
https://codereview.chromium.org/338713002/diff/40001/Source/web/WebViewImpl.h
> > File Source/web/WebViewImpl.h (left):
> > 
> >
>
https://codereview.chromium.org/338713002/diff/40001/Source/web/WebViewImpl.h...
> > Source/web/WebViewImpl.h:694: MediaKeysClientImpl m_mediaKeysClientImpl;
> > m_mediaKeysClientImpl instance is only used by MediaKeyController. So, I
> thought
> > that it would be good to move ownership to MediaKeyController. However, I
> agree
> > that this is not big worth to do because this is trivial refactoring. To be
> > honest, I don't understand where memory leak happens in my last patch. Last
> one
> > is to pass OwnPtr to MediaKeyController's member variable, then it will be
> free
> > when going out of MediaKeyController. Anyway, now I just would like to
remove
> > unused provideMediaKeysTo() in MediaKeyClient.h. Because MediaKeyController
> has
> > already same function and it is only being used by WebViewImpl.cpp. It looks
> the
> > function is duplicated.
> 
> Abarth, could you take a look this cl again ?

Is there any owner who can take a look last patch ?

[abarth-chromium, 2014-06-30 02:42:00]

lgtm

[commit-bot: I haz the power, 2014-06-30 02:42:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/338713002/60001

[commit-bot: I haz the power, 2014-06-30 03:47:44]

Change committed as 177184