Issue 338633007: Check for degenerate edges in cubic->quad conversion called by convex path renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338633007: Check for degenerate edges in cubic->quad conversion called by convex path renderer. (Closed)

Created:
6 years, 6 months ago by bsalomon

Modified:
6 years, 6 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Check for degenerate edges in cubic->quad conversion called by convex path renderer. Cubics that are nearly degenerate now make it down here via the convex path renderer. They used to get filtered out by the path iterator but that was problematic. We wound up producing NaN vertices. BUG=2677 Committed: https://skia.googlesource.com/skia/+/3935a7bfe64293edf9b06527f59d657ff4e280cb

Patch Set 1 #

Patch Set 2 : update comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -37 lines)			Patch
	M	src/gpu/GrPathUtils.cpp	View	1	1 chunk	+44 lines, -37 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/338633007/20001

6 years, 6 months ago (2014-06-19 19:18:24 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-19 19:33:13 UTC) #5

Message was sent while issue was closed.

Change committed as 3935a7bfe64293edf9b06527f59d657ff4e280cb

Expand Messages | Collapse Messages