Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gpu/command_buffer/client/BUILD.gn

Issue 338633004: GN: Fix up various gpu targets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gpu/BUILD.gn ('K') | « gpu/BUILD.gn ('k') | gpu/command_buffer/service/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/BUILD.gn
diff --git a/gpu/command_buffer/client/BUILD.gn b/gpu/command_buffer/client/BUILD.gn
index 535bb4913327ae689f43e88f1e06e3dd70cc3f4a..2f7f05f07e64c59371b3745eabb0d9ce9cb7102e 100644
--- a/gpu/command_buffer/client/BUILD.gn
+++ b/gpu/command_buffer/client/BUILD.gn
@@ -148,12 +148,8 @@ component("gl_in_process_context") {
component("gles2_c_lib") {
sources = gles2_c_lib_source_files
- defines = [ "GLES2_C_LIB_IMPLEMENTATION" ]
- if (is_win) {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ] # size_t to int truncation.
- }
+ defines = [ "GLES2_C_LIB_IMPLEMENTATION" ]
deps = [
":client",
@@ -162,5 +158,10 @@ component("gles2_c_lib") {
"//base/third_party/dynamic_annotations",
"//gpu/command_buffer/common",
]
+
+ if (is_win) {
piman 2014/06/16 19:18:32 nit: indent?
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ cflags = [ "/wd4267" ] # size_t to int truncation.
+ }
}
« gpu/BUILD.gn ('K') | « gpu/BUILD.gn ('k') | gpu/command_buffer/service/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698