Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 338633002: Remove the inheritance from PageTestResults to unittest.TestResult. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org, bajones, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the inheritance from PageTestResults to unittest.TestResult. BUG=383100 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278287

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address Ken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -62 lines) Patch
M tools/telemetry/telemetry/results/gtest_test_results.py View 1 3 chunks +20 lines, -31 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_test_results_unittest.py View 2 chunks +34 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 3 chunks +20 lines, -25 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-16 17:12:19 UTC) #1
nednguyen
+kbr since this may potentially affect your gpu tests.
6 years, 6 months ago (2014-06-16 17:17:18 UTC) #2
Ken Russell (switch to Gerrit)
LGTM as this looks like it's working well on the GPU bots. I don't see ...
6 years, 6 months ago (2014-06-16 20:21:42 UTC) #3
nednguyen
https://codereview.chromium.org/338633002/diff/40001/tools/telemetry/telemetry/results/gtest_test_results.py File tools/telemetry/telemetry/results/gtest_test_results.py (left): https://codereview.chromium.org/338633002/diff/40001/tools/telemetry/telemetry/results/gtest_test_results.py#oldcode49 tools/telemetry/telemetry/results/gtest_test_results.py:49: super(GTestTestResults, self).startTest(test) On 2014/06/16 20:21:42, Ken Russell wrote: > ...
6 years, 6 months ago (2014-06-16 20:36:13 UTC) #4
Ken Russell (switch to Gerrit)
LGTM again.
6 years, 6 months ago (2014-06-16 20:59:08 UTC) #5
dtu
lgtm. Feels cleaner, despite duplicating GTest formatting
6 years, 6 months ago (2014-06-18 21:23:12 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-18 21:33:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/338633002/60001
6 years, 6 months ago (2014-06-18 21:34:53 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 06:48:41 UTC) #9
Message was sent while issue was closed. 
Change committed as 278287

Powered by Google App Engine
This is Rietveld 408576698