Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 33863002: Added pref for snapshot document collapsed state (Closed)

Created:
7 years, 2 months ago by apiccion
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added pref for snapshot document collapsed state * Added boolean preference to persist other devices snapshot document collapsed/expanded state. * Added JNI bridge to set/expand state. NOTRY=true BUG=294401 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232874

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Refactor #

Total comments: 17

Patch Set 4 : #

Total comments: 6

Patch Set 5 : Sky nits #

Patch Set 6 : rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -66 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ForeignSessionHelper.java View 1 2 2 chunks +0 lines, -22 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java View 1 2 3 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/android/foreign_session_helper.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/android/foreign_session_helper.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
A chrome/browser/android/new_tab_page_prefs.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/android/new_tab_page_prefs.cc View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 1 chunk +22 lines, -11 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
apiccion
This CL is ready for review.
7 years, 2 months ago (2013-10-21 22:22:50 UTC) #1
newt (away)
Are you planning to use SnapshotDocumentHelper.java for more than just storing the preference? If you ...
7 years, 2 months ago (2013-10-21 23:27:45 UTC) #2
Yaron
On 2013/10/21 23:27:45, newt wrote: > Are you planning to use SnapshotDocumentHelper.java for more than ...
7 years, 2 months ago (2013-10-22 00:23:31 UTC) #3
aurimas (slooooooooow)
On 2013/10/22 00:23:31, Yaron wrote: > On 2013/10/21 23:27:45, newt wrote: > > Are you ...
7 years, 2 months ago (2013-10-22 00:32:12 UTC) #4
apiccion
Grouped other devices prefs into one class. Let me know what you think of this ...
7 years, 1 month ago (2013-10-30 22:53:43 UTC) #5
newt (away)
aurimas or yfriedman, could you take a look too? I'm not very familiar with how ...
7 years, 1 month ago (2013-10-30 23:47:51 UTC) #6
Yaron
This seems fine and is consistent with elsewhere. I do worry if we have to ...
7 years, 1 month ago (2013-10-31 20:57:34 UTC) #7
apiccion
https://codereview.chromium.org/33863002/diff/100001/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java File chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java (right): https://codereview.chromium.org/33863002/diff/100001/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java#newcode11 chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java:11: * This class exposes to Java information about snapshot ...
7 years, 1 month ago (2013-11-01 23:30:31 UTC) #8
newt (away)
lgtm https://codereview.chromium.org/33863002/diff/100001/chrome/browser/android/new_tab_page_prefs.h File chrome/browser/android/new_tab_page_prefs.h (right): https://codereview.chromium.org/33863002/diff/100001/chrome/browser/android/new_tab_page_prefs.h#newcode44 chrome/browser/android/new_tab_page_prefs.h:44: Profile* profile_; // weak On 2013/11/01 23:30:32, apiccion ...
7 years, 1 month ago (2013-11-01 23:49:18 UTC) #9
Yaron
lgtm but I think you need a chrome/browser/prefs OWNER
7 years, 1 month ago (2013-11-02 01:04:33 UTC) #10
apiccion
@pam Seeking owners approval for: chrome/browser/prefs/browser_prefs.cc
7 years, 1 month ago (2013-11-02 01:12:11 UTC) #11
Pam (message me for reviews)
LGTM once nits below are fixed. - Pam https://codereview.chromium.org/33863002/diff/200001/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/33863002/diff/200001/chrome/browser/prefs/browser_prefs.cc#newcode363 chrome/browser/prefs/browser_prefs.cc:363: #if ...
7 years, 1 month ago (2013-11-02 08:27:24 UTC) #12
apiccion
https://codereview.chromium.org/33863002/diff/200001/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/33863002/diff/200001/chrome/browser/prefs/browser_prefs.cc#newcode363 chrome/browser/prefs/browser_prefs.cc:363: #if defined(OS_ANDROID) On 2013/11/02 08:27:25, Pam (also PM for ...
7 years, 1 month ago (2013-11-03 17:52:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/33863002/360001
7 years, 1 month ago (2013-11-03 17:53:12 UTC) #14
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96983
7 years, 1 month ago (2013-11-03 20:11:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/33863002/360001
7 years, 1 month ago (2013-11-03 23:34:17 UTC) #16
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97022
7 years, 1 month ago (2013-11-04 01:41:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/33863002/360001
7 years, 1 month ago (2013-11-04 18:28:11 UTC) #18
commit-bot: I haz the power
Failed to apply patch for chrome/browser/prefs/browser_prefs.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-04 18:28:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/33863002/700001
7 years, 1 month ago (2013-11-04 18:35:39 UTC) #20
commit-bot: I haz the power
Failed to apply patch for chrome/browser/prefs/browser_prefs.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-04 18:35:47 UTC) #21
newt (away)
Looks like you need to rebase against origin/master. > git checkout your_branch > git branch ...
7 years, 1 month ago (2013-11-04 18:47:40 UTC) #22
newt (away)
On 2013/11/04 18:47:40, newt wrote: > Looks like you need to rebase against origin/master. > ...
7 years, 1 month ago (2013-11-04 18:48:18 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/33863002/770001
7 years, 1 month ago (2013-11-04 19:23:03 UTC) #24
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97458
7 years, 1 month ago (2013-11-05 00:42:14 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/33863002/770001
7 years, 1 month ago (2013-11-05 01:06:02 UTC) #26
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 01:33:06 UTC) #27
Message was sent while issue was closed.
Change committed as 232874

Powered by Google App Engine
This is Rietveld 408576698