Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 338623002: Added FEC policy per stream, which is translated to an FEC protection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/reliable_quic_stream_peer.cc ('k') | net/tools/quic/test_tools/quic_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index c9c73f3d0bd6669c4ea03f37b590f0c491b2e9b1..25779259714f4383c0fc894ef25c34055b8444a5 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -636,9 +636,6 @@ TEST_P(EndToEndTest, DISABLED_LargePostZeroRTTFailure) {
}
TEST_P(EndToEndTest, LargePostFEC) {
- // TODO(jri): Set FecPolicy to always protect on client_->stream_.
- // This test currently does not do any FEC protection.
-
// Connect without packet loss to avoid issues with losing handshake packets,
// and then up the packet loss rate (b/10126687).
ASSERT_TRUE(Initialize());
@@ -650,7 +647,9 @@ TEST_P(EndToEndTest, LargePostFEC) {
// Enable FEC protection.
QuicPacketCreator* creator = QuicConnectionPeer::GetPacketCreator(
client_->client()->session()->connection());
- creator->set_max_packets_per_fec_group(6);
+ creator->set_max_packets_per_fec_group(3);
+ // Set FecPolicy to always protect data on all streams.
+ client_->SetFecPolicy(PROTECT_ALWAYS);
string body;
GenerateBody(&body, 10240);
« no previous file with comments | « net/quic/test_tools/reliable_quic_stream_peer.cc ('k') | net/tools/quic/test_tools/quic_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698