Issue 338613003: Disable use of fcntl in fdopen for nacl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338613003: Disable use of fcntl in fdopen for nacl. (Closed)

Created:
6 years, 6 months ago by bradn

Modified:
6 years, 6 months ago

Reviewers:
Roland McGrath

CC:
native-client-reviews_googlegroups.com, Mark Seaborn

Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master

Visibility:
Public.

Disable use of fcntl in fdopen for nacl. As fcntl is not implemented currently in nacl, nor likely to be, skip using it to check file descriptor state inside fdopen. BUG=None TEST=None R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=e789f81

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	libio/iofdopen.c	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Roland McGrath

Please add a test to the NaCl tree that will break if this regresses. That's ...

6 years, 6 months ago (2014-06-13 21:32:57 UTC) #2

bradn

6 years, 6 months ago (2014-06-13 23:27:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as re789f81 (presubmit successful).