Cancel posted write callbacks in Disconnect().

Cancel posted write callbacks in Disconnect().

Add a second WeakPtrFactory for the posted write callbacks. Invalidate
the weak pointers created by this factory in Disconnect().

R=jgraettinger@chromium.org,rch@chromium.org,rsleevi@chromium.org
BUG=362733
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277158

[wtc, 2014-06-13 18:03:50]

This is a brute-force CL to fix the problem with the current fix for bug 355511.

Ideally we should also step back and see if there are other ways to fix bug
355511. But now we have a solution in hand.

https://codereview.chromium.org/338583003/diff/1/net/spdy/spdy_proxy_client_s...
File net/spdy/spdy_proxy_client_socket.cc (right):

https://codereview.chromium.org/338583003/diff/1/net/spdy/spdy_proxy_client_s...
net/spdy/spdy_proxy_client_socket.cc:42: auth_handler_factory)),

This change was made by "git cl format". Let me know if you would rather exclude
this unrelated formatting change from the CL.

[Ryan Hamilton, 2014-06-13 19:02:06]

lgtm. curious to get jgreatinger's opinion.

https://codereview.chromium.org/338583003/diff/20001/net/spdy/spdy_proxy_clie...
File net/spdy/spdy_proxy_client_socket.cc (right):

https://codereview.chromium.org/338583003/diff/20001/net/spdy/spdy_proxy_clie...
net/spdy/spdy_proxy_client_socket.cc:497:
base::Bind(&SpdyProxyClientSocket::RunCallback,
If this is the only place RunCallback is called, how 'bout making the method
something like:

void RunWriteCallback(in rv) {
  ResetAdnReturn(&write_callback_).run(rv);
}

[wtc, 2014-06-13 23:33:21]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-06-13 23:34:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wtc@chromium.org/338583003/20001

[wtc, 2014-06-14 00:31:52]

https://codereview.chromium.org/338583003/diff/20001/net/spdy/spdy_proxy_clie...
File net/spdy/spdy_proxy_client_socket.cc (right):

https://codereview.chromium.org/338583003/diff/20001/net/spdy/spdy_proxy_clie...
net/spdy/spdy_proxy_client_socket.cc:497:
base::Bind(&SpdyProxyClientSocket::RunCallback,

On 2014/06/13 19:02:06, Ryan Hamilton wrote:
> If this is the only place RunCallback is called, how 'bout making the method
> something like:
> 
> void RunWriteCallback(in rv) {
>   ResetAdnReturn(&write_callback_).run(rv);
> }

Ryan, did you suggest this because it is expensive to bind write_callback_ to a
"closure" task?

This should work. We can also leave write_buffer_len_ unchanged and define
RunWriteCallback as

void RunWriteCallback() {
  int rv = write_buffer_len_;
  write_buffer_len_ = 0;
  ResetAdnReturn(&write_callback_).run(rv);
}

Note: we still need a separate WeakPtrFactory so that this can be canceled in
Disconnect().

[wtc, 2014-06-14 01:22:11]

Johnny: Please review this CL.

I misspelled your email address earlier, which is why you were not notified of
this CL. Sorry.

[commit-bot: I haz the power, 2014-06-14 02:26:40]

Change committed as 277158

[Johnny, 2014-06-16 17:50:37]

lgtm.