components/signin/core/browser/signin_metrics.h - Issue 338573002: Differentiate primary account compares on GAIA cookie presence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_metrics.h

Issue 338573002: Differentiate primary account compares on GAIA cookie presence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/account_reconcilor.cc ('k') | components/signin/core/browser/signin_metrics.cc » ('j') | components/signin/core/browser/signin_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/signin_metrics.h

diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h

index 0dfa97a06ddb9c2ff6c83e2fa2b18d268269bfb0..08198667454161a5c6fb7af678f275cbeb1b7fc8 100644

--- a/components/signin/core/browser/signin_metrics.h

+++ b/components/signin/core/browser/signin_metrics.h

@@ -23,7 +23,8 @@ void LogSigninAccountReconciliation(int total_number_accounts,

int count_added_to_cookie_jar,

int count_added_to_token,

bool primary_accounts_same,

- bool is_first_reconcile);

+ bool is_first_reconcile,

+ int pre_count_gaia_cookies);

Alexei Svitkine (slow) 2014/06/17 19:43:04 Document this param in the comment.

// Track a successful signin.

void LogSigninAddAccount();