LayoutTests/fast/events/hit-test-counts-expected.txt - Issue 338543003: Gesture event hit test refactoring and reduction

Side by Side Diff: LayoutTests/fast/events/hit-test-counts-expected.txt

Issue 338543003: Gesture event hit test refactoring and reduction (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Merge with trunk Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.html ('K') | « LayoutTests/fast/css/resize-corner-tracking-touch.html ('k') | LayoutTests/touchadjustment/rotated-node.html » ('j') | Source/core/page/EventHandler.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Count how many hit tests are required for various event scenarios. Hit tests can be expensive and it's often tempting to add more. These values should only ever be changed to go down, not up.	1 Count how many hit tests are required for various event scenarios. Hit tests can be expensive and it's often tempting to add more. These values should only ever be changed to go down, not up.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 PASS successfullyParsed is true	6 PASS successfullyParsed is true

7	7

8 TEST COMPLETE	8 TEST COMPLETE

9 Event on a simple div	9 Event on a simple div

10 ---------------------	10 ---------------------

11 Initial: 0	11 Initial: 0

12 MouseMove: 1	12 MouseMove: 1

13 MouseDown: 3	13 MouseDown: 3

14 MouseUp: 1	14 MouseUp: 1

15 Wheel: 1	15 Wheel: 1

16 TouchStart: 1	16 TouchStart: 1

17 TouchMove: 0	17 TouchMove: 0

18 TouchEnd: 0	18 TouchEnd: 0

19 GestureTapDown: 3	19 GestureTapDown: 1

20 GestureShowPress: 5	20 GestureShowPress: 2

21 GestureTap: 7	21 GestureTap: 6

22 GestureScrollBegin: 2	22 GestureScrollBegin: 1

23 GestureTapCancel: 2	23 GestureTapCancel: 1

24 GestureScrollUpdate: 0	24 GestureScrollUpdate: 0

25 GestureScrollEnd: 0	25 GestureScrollEnd: 0

26	26

27 Event entirely over one iframe nested in another	27 Event entirely over one iframe nested in another

28 ---------------------	28 ---------------------

29 Initial: 0 0 0	29 Initial: 0 0 0

30 MouseMove: 1 1 1	30 MouseMove: 1 1 1

31 MouseDown: 2 2 3	31 MouseDown: 2 2 3

32 MouseUp: 1 1 1	32 MouseUp: 1 1 1

33 Wheel: 1 1 1	33 Wheel: 1 1 1

34 TouchStart: 1 1 1	34 TouchStart: 1 1 1

35 TouchMove: 0 0 0	35 TouchMove: 0 0 0

36 TouchEnd: 0 0 0	36 TouchEnd: 0 0 0

37 GestureTapDown: 5 5 5	37 GestureTapDown: 1 1 1

38 GestureShowPress: 7 7 7	38 GestureShowPress: 2 2 2

39 GestureTap: 3 3 7	39 GestureTap: 2 2 6

40 GestureScrollBegin: 4 4 4	40 GestureScrollBegin: 1 1 1

41 GestureTapCancel: 2 2 2	41 GestureTapCancel: 1 1 1

42 GestureScrollUpdate: 0 0 0	42 GestureScrollUpdate: 0 0 0

43 GestureScrollEnd: 0 0 0	43 GestureScrollEnd: 0 0 0

44	44

45 Event near boundary of two iframes	45 Event near boundary of two iframes

46 ---------------------	46 ---------------------

47 Initial: 0 0 0	47 Initial: 0 0 0

48 MouseMove: 1 1 1	48 MouseMove: 1 1 1

49 MouseDown: 2 3 0	49 MouseDown: 2 3 0

50 MouseUp: 1 1 0	50 MouseUp: 1 1 0

51 Wheel: 1 1 0	51 Wheel: 1 1 0

52 TouchStart: 1 1 0	52 TouchStart: 1 1 0

53 TouchMove: 0 0 0	53 TouchMove: 0 0 0

54 TouchEnd: 0 0 0	54 TouchEnd: 0 0 0

55 GestureTapDown: 5 14 50	55 GestureTapDown: 1 4 16

56 GestureShowPress: 7 19 67	56 GestureShowPress: 2 8 32
	esprehn 2014/06/27 08:33:58 woah, we did 67 hit tests before? woah, we did 67 hit tests before? Rick Byers 2014/06/27 15:38:23 Worse! Total of 162 for the TapDown and ShowPress Show quoted text On 2014/06/27 08:33:58, esprehn wrote: > woah, we did 67 hit tests before? Worse! Total of 162 for the TapDown and ShowPress and probably another big chunk for the Tap but it's not showing here because EventSender currently always sends a 0 radius for tap. I'm fixing that separately. This is the issue I found yesterday in the previous CL: https://codereview.chromium.org/354613002/#msg3. It's an edge case (a tap which covers multiple nested iframes) that triggers a pathological hit-test explosion in touch adjustment (which searches for the best node within the tap bounding box). It's why I added this third section to the test. I could probably come up with something with huge multi-second delays if I added a few more tiny nested iframes :-). Anyway this should be rare in practice, but I'll get it down to something reasonable.
57 GestureTap: 3 7 0	57 GestureTap: 2 6 0

58 GestureScrollBegin: 3 3 0	58 GestureScrollBegin: 1 1 0

59 GestureTapCancel: 2 2 0	59 GestureTapCancel: 1 1 0

60 GestureScrollUpdate: 0 0 0	60 GestureScrollUpdate: 0 0 0

61 GestureScrollEnd: 0 0 0	61 GestureScrollEnd: 0 0 0

62	62

63	63

OLD	NEW