Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/platform/heap/Visitor.h

Issue 338533002: Fix null pointer crash with adjustAndMark (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Visitor.h
diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h
index 15ec4047efd05d7e9dfec7f2ff92904d096cca11..56cfbef708c3273e745fb264ef1d08e098b867f4 100644
--- a/Source/platform/heap/Visitor.h
+++ b/Source/platform/heap/Visitor.h
@@ -621,7 +621,8 @@ class DefaultTraceTrait<T, true> {
public:
static void mark(Visitor* visitor, const T* self)
{
- self->adjustAndMark(visitor);
+ if (self)
sof 2014/06/13 09:12:54 Would it be possible move this "up" a bit? i.e., w
Erik Corry 2014/06/13 09:40:26 This is just for things that need adjustAndMark, s
sof 2014/06/13 09:49:35 alright, perhaps so.
+ self->adjustAndMark(visitor);
}
#ifndef NDEBUG
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698