Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 338523003: Revise unittest for 'LD' in 'make_global_settings' (Closed)

Created:
5 years, 3 months ago by yukawa
Modified:
5 years, 3 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com, Torne, Ami GONE FROM CHROMIUM
Visibility:
Public.

Description

Revise unittest for 'LD' in 'make_global_settings' This is a follow up CL for r1937. This is just a revise of a unittest and does not changes existing functionality. It turned out that we need to specify GYP_CROSSCOMPILE=1 to test 'LD'/'LD.host' properly. Expected results, which are expected to be describing the current behavior, are updated accordingly. BUG=gyp:434 TEST=unittest R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1939

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M test/make_global_settings/ld/gyptest-make_global_settings_ld.py View 3 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yukawa
Hi Scott, Can you take a look at this? Thanks!
5 years, 3 months ago (2014-06-13 10:54:03 UTC) #1
scottmg
lgtm
5 years, 3 months ago (2014-06-13 20:22:14 UTC) #2
yukawa
5 years, 3 months ago (2014-06-14 05:46:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698