Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 338513002: MIPS: Unbreak big-endian build after r21774.

Created:
6 years, 6 months ago by palfia
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Unbreak big-endian build after r21774. This fixes the STATIC_ASSERTS in the big-endian build. BUG=

Patch Set 1 #

Patch Set 2 : Fix kMapInstanceTypeOffset and InstanceType&BitField order on big endian. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M include/v8.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
6 years, 6 months ago (2014-06-13 01:01:35 UTC) #1
Paul Lind
Looks good to me. Danno, can you PTAL?
6 years, 6 months ago (2014-06-13 01:08:26 UTC) #2
Paul Lind
6 years, 6 months ago (2014-06-16 04:49:59 UTC) #3
patchset 2 NOT lgtm. It fails to build little endian arch's.

Powered by Google App Engine
This is Rietveld 408576698