Do not filter the picker window with Aura.

chrome/browser/ui/views/desktop_media_picker_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/desktop_media_picker.h"
 
 #include "base/callback.h"
 #include "chrome/browser/media/desktop_media_list.h"
 #include "chrome/browser/media/desktop_media_list_observer.h"
 #include "chrome/browser/ui/ash/ash_util.h"
@@ skipping 547 matching lines @@
   views::Widget* widget = NULL;
   if (parent_web_contents)
     widget = CreateWebModalDialogViews(this, parent_web_contents);
   else
     widget = DialogDelegate::CreateDialogWidget(this, context, parent_window);
 
   // DesktopMediaList needs to know the ID of the picker window which
   // matches the ID it gets from the OS. Depending on the OS and configuration
   // we get this ID differently.
   content::DesktopMediaID::Id dialog_window_id = 0;
+
+  // If there is |parent_window| or |parent_web_contents|, the picker window
+  // is embedded in the parent and does not have its own native window id, so we
+  // do not filter in that case.
+  if (!parent_window && !parent_web_contents) {

[Sergey Ulanov, 2014/06/16 21:48:43]

You need just !parent_web_contents. parent_window is not relevant when deciding
what type of window to show - see line 589. You may need !parent_window in line
581, for the case when Ash is not active.

[jiayl, 2014/06/16 22:07:34]

That's not true. If the parent_web_contents is NULL but parent_window is not
NULL, the picker is still embedded in the parent_window and we should not
filter. I've tested it by always setting parent_web_contents NULL.

[Sergey Ulanov, 2014/06/16 22:14:00]

Did you try it with Ash? I think with Ash you'll get a different window and you
still need filtering even when parent_window!=null.

 #if defined(USE_ASH)
-  if (chrome::IsNativeWindowInAsh(widget->GetNativeWindow())) {
-    dialog_window_id = content::DesktopMediaID::RegisterAuraWindow(
-        widget->GetNativeWindow()).id;
-    DCHECK_NE(dialog_window_id, 0);
-  }
+    if (chrome::IsNativeWindowInAsh(widget->GetNativeWindow())) {
+      dialog_window_id = content::DesktopMediaID::RegisterAuraWindow(
+          widget->GetNativeWindow()).id;
+      DCHECK_NE(dialog_window_id, 0);
+    }
 #endif
-  if (dialog_window_id == 0) {
-    dialog_window_id = AcceleratedWidgetToDesktopMediaId(
-        widget->GetNativeWindow()->GetHost()->GetAcceleratedWidget());
+
+    if (dialog_window_id == 0) {
+      dialog_window_id = AcceleratedWidgetToDesktopMediaId(
+          widget->GetNativeWindow()->GetHost()->GetAcceleratedWidget());
+    }
   }
 
   list_view_->StartUpdating(dialog_window_id);
 
   if (parent_web_contents) {
     web_modal::WebContentsModalDialogManager* manager =
         web_modal::WebContentsModalDialogManager::FromWebContents(
             parent_web_contents);
     manager->ShowModalDialog(widget->GetNativeView());
   } else {
@@ skipping 136 matching lines @@
       base::Bind(callback_, source));
   callback_.Reset();
 }
 
 }  // namespace
 
 // static
 scoped_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() {
   return scoped_ptr<DesktopMediaPicker>(new DesktopMediaPickerViews());
 }