Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/data_url_unittest.cc

Issue 338503006: Allow data urls to have a fragment part. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix review issues Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/data_url.cc ('K') | « net/base/data_url.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/data_url_unittest.cc
diff --git a/net/base/data_url_unittest.cc b/net/base/data_url_unittest.cc
index 43f881f7084e86a478970ca2082e00cdbdde519d..7eb8697428f4f492c388386897208ce543f05a78 100644
--- a/net/base/data_url_unittest.cc
+++ b/net/base/data_url_unittest.cc
@@ -169,7 +169,99 @@ TEST(DataURLTest, Parse) {
"",
"" },
- // TODO(darin): add more interesting tests
+ // Simple fragment (valid).
+ { "data:,test#foo",
+ true,
+ "text/plain",
+ "US-ASCII",
+ "test" },
+
+ // Fragment base64 (valid).
+ { "data:text/html;base64,PCFkb2N0eXBlIGh0bWw+PHN0eWxlPmRpdiB7IGJhY2tncm91bmQtY29sb3I6IHJlZDsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6MjAwcHg7IH0gOnRhcmdldCB7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyB9PC9zdHlsZT48ZGl2IGlkPSd0YXJnZXQnPjwvZGl2Pg==#target",
+ true,
+ "text/html",
+ "US-ASCII",
+ "<!doctype html><style>div { background-color: red; width: 200px; height:200px; } :target { background-color: green; }</style><div id='target'></div>" },
+
+ // Fragment escaped base64 (invalid).
+ { "data:text/html;base64,PCFkb2N0eXBlIGh0bWw+PHN0eWxlPmRpdiB7IGJhY2tncm91bmQtY29sb3I6IHJlZDsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6MjAwcHg7IH0gOnRhcmdldCB7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyB9PC9zdHlsZT48ZGl2IGlkPSd0YXJnZXQnPjwvZGl2Pg==%23target",
+ false,
+ "",
+ "",
+ "" },
+
+ // html fragment (valid).
+ { "data:text/html,%3C!doctype%20html%3E%3Cstyle%3Ediv%20%7B%20background-color:%20red;%20width:%20200px;%20height:200px;%20%7D%20:target%20%7B%20background-color:%20green;%20%7D%3C/style%3E%3Cdiv%20id='target'%3E%3C/div%3E#target",
+ true,
+ "text/html",
+ "US-ASCII",
+ "<!doctype html><style>div { background-color: red; width: 200px; height:200px; } :target { background-color: green; }</style><div id='target'></div>" },
+
+ // svg with media type extension (valid).
+ { "data:image/svg+xml;foo=bar,%3Csvg%20xmlns=%22http://www.w3.org/2000/svg%22%20viewBox=%220%200%20100%20100%22%3E%3Cstyle%3E:target%20%7B%20fill:%20blue%20%7D%3C/style%3E%3Ccircle%20id=%22target%22%20cx=%2250%22%20cy=%2250%22%20r=%2250%22%20fill=%22green%22/%3E%3C/svg%3E",
+ true,
+ "image/svg+xml",
+ "US-ASCII",
+ "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 100 100\"><style>:target { fill: blue }</style><circle id=\"target\" cx=\"50\" cy=\"50\" r=\"50\" fill=\"green\"/></svg>" },
+
+ // svg fragment (valid).
+ { "data:image/svg+xml,%3Csvg%20xmlns=%22http://www.w3.org/2000/svg%22%20viewBox=%220%200%20100%20100%22%3E%3Cstyle%3E:target%20%7B%20fill:%20blue%20%7D%3C/style%3E%3Ccircle%20id=%22target%22%20cx=%2250%22%20cy=%2250%22%20r=%2250%22%20fill=%22green%22/%3E%3C/svg%3E#target",
+ true,
+ "image/svg+xml",
+ "US-ASCII",
+ "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 100 100\"><style>:target { fill: blue }</style><circle id=\"target\" cx=\"50\" cy=\"50\" r=\"50\" fill=\"green\"/></svg>" },
+
+ // html fragment escaped (valid).
+ { "data:text/html,%3C!doctype%20html%3E%3Cstyle%3Ediv%20%7B%20background-color:%20red;%20width:%20200px;%20height:200px;%20%7D%20:target%20%7B%20background-color:%20green;%20%7D%3C/style%3E%3Cdiv%20id='target'%3E%3C/div%3E%23target",
+ true,
+ "text/html",
+ "US-ASCII",
+ "<!doctype html><style>div { background-color: red; width: 200px; height:200px; } :target { background-color: green; }</style><div id='target'></div>#target" },
+
+ // Query base64 (valid).
+ { "data:text/html;base64,PCFkb2N0eXBlIGh0bWw+PHN0eWxlPmRpdiB7IGJhY2tncm91bmQtY29sb3I6IHJlZDsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6MjAwcHg7IH0gOnRhcmdldCB7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyB9PC9zdHlsZT48ZGl2IGlkPSd0YXJnZXQnPjwvZGl2Pg==?foo=bar",
+ true,
+ "text/html",
+ "US-ASCII",
+ "<!doctype html><style>div { background-color: red; width: 200px; height:200px; } :target { background-color: green; }</style><div id='target'></div>" },
+
+ // Query escaped base64 (invalid).
+ { "data:text/html;base64,PCFkb2N0eXBlIGh0bWw+PHN0eWxlPmRpdiB7IGJhY2tncm91bmQtY29sb3I6IHJlZDsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6MjAwcHg7IH0gOnRhcmdldCB7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyB9PC9zdHlsZT48ZGl2IGlkPSd0YXJnZXQnPjwvZGl2Pg==%3ffoo=bar",
+ false,
+ "",
+ "",
+ "" },
+
+ // Query (valid).
+ { "data:text/html,%3C!doctype%20html%3E%3Cdiv%3E%3C/div%3E?foo=bar",
+ true,
+ "text/html",
+ "US-ASCII",
+ "<!doctype html><div></div>" },
+
+ // Query escaped (valid).
+ { "data:text/html,%3C!doctype%20html%3E%3Cdiv%3E%3C/div%3E%3ffoo=bar",
+ true,
+ "text/html",
+ "US-ASCII",
+ "<!doctype html><div></div>?foo=bar" },
+
+
+ // base64 as parameter (should be ignored).
+ { "data:text/plain;base64=paramvalue,test",
+ true,
+ "text/plain",
+ "US-ASCII",
+ "test" },
+
+ // base64 extension in wrong position.
+ { "data:text/plain;base64;x=y,dGVzdA==",
+ true,
+ "text/plain",
+ "US-ASCII",
+ "test" },
+
+ // TODO(darin): add more interesting tests
};
for (size_t i = 0; i < arraysize(tests); ++i) {
« net/base/data_url.cc ('K') | « net/base/data_url.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698