Allow data urls to have a fragment part.

net/base/data_url.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE: based loosely on mozilla's nsDataChannel.cpp
 
 #include <algorithm>
 
 #include "net/base/data_url.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "net/base/escape.h"
 #include "net/base/mime_util.h"
 #include "url/gurl.h"
 
 namespace net {
 
 // static
 bool DataURL::Parse(const GURL& url, std::string* mime_type,
                     std::string* charset, std::string* data) {
   DCHECK(mime_type->empty());
   DCHECK(charset->empty());
-  std::string::const_iterator begin = url.spec().begin();
-  std::string::const_iterator end = url.spec().end();
+  DCHECK(url.SchemeIs("data"));
 
-  std::string::const_iterator after_colon = std::find(begin, end, ':');
-  if (after_colon == end)
-    return false;
-  ++after_colon;
+  const std::string path = url.path();

[asanka, 2014/08/13 15:41:41]

Shall we try to avoid constructing strings? I believe that's why the previous
code was using the iterators over the spec.

i.e. begin = url.possibly_invalid_spec().begin() +
url.parsed_for_possibly_invalid_spec().path.begin;
   end = ....path.end();

You'd also want to DCHECK(url.is_valid()).

+  std::string::const_iterator begin = path.begin();
+  std::string::const_iterator end = path.end();
 
-  std::string::const_iterator comma = std::find(after_colon, end, ',');
+  std::string::const_iterator comma = std::find(begin, end, ',');
   if (comma == end)
     return false;
 
   std::vector<std::string> meta_data;
-  std::string unparsed_meta_data(after_colon, comma);
+  std::string unparsed_meta_data(begin, comma);
   base::SplitString(unparsed_meta_data, ';', &meta_data);
 
   std::vector<std::string>::iterator iter = meta_data.begin();
   if (iter != meta_data.end()) {
     mime_type->swap(*iter);
     StringToLowerASCII(mime_type);
     ++iter;
   }
 
   static const char kBase64Tag[] = "base64";
@@ skipping 68 matching lines @@
       temp_data.resize(length + padding_needed, '=');
     }
     return base::Base64Decode(temp_data, data);
   }
 
   temp_data.swap(*data);
   return true;
 }
 
 }  // namespace net