tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 0ef82fff9f2756cf671835d0477609ee582d3078..b5773c63c1921930cb0328aa1ea72e24d0002b1f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3201,6 +3201,78 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="DataReductionProxy.HeaderTamperDetectionHTTP">
+  <owner>xingx@chromium.org</owner>
+  <owner>bolian@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    For each carrier, the total number of HTTP responses that have been checked

[Alexei Svitkine (slow), 2014/08/05 15:24:10]

Can you add an enum definition to histograms.xml documenting a set of known
carrier ids and reference it from this histogram (and every other "For each
carrier" one too).

[xingx1, 2014/08/05 18:08:50]

There are hundreds (or maybe more :) ) of them
(http://en.wikipedia.org/wiki/Mobile_country_code).

And there exist histograms use the same buckets (check
"NCN.NetworkOperatorMCCMNC")

I'm leaving it as is for now.

[Alexei Svitkine (slow), 2014/08/05 19:41:42]

Okay, please add a sentence to each description pointing at that URL, so people
know how to decode them.

+    for tampering. This assumes the data reduction proxy injected fingerprints
+    have not been tampered with. Only the data reduction proxy responses with
+    200 OK response code are checked.
+  </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.HeaderTamperDetectionHTTP_Total">
+  <owner>xingx@chromium.org</owner>
+  <owner>bolian@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The total number of HTTP responses that have been checked for tampering.
+    This assumes the data reduction proxy injected fingerprints have not been
+    tampered with. Only the data reduction proxy responses with 200 OK response
+    code are checked.
+  </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.HeaderTamperDetectionHTTPS">
+  <owner>xingx@chromium.org</owner>
+  <owner>bolian@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    For each carrier, the total number of HTTPS responses that have been checked
+    for tampering. This assumes the data reduction proxy injected fingerprints
+    have not been tampered with. Only the data reduction proxy responses with
+    200 OK response code are checked.
+  </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.HeaderTamperDetectionHTTPS_Total">

[Alexei Svitkine (slow), 2014/08/05 15:24:10]

Perhaps the _Total versions of the histograms can be specified via a suffix list
too?

[xingx1, 2014/08/05 18:08:50]

Done.

+  <owner>xingx@chromium.org</owner>
+  <owner>bolian@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The total number of HTTPS responses that have been checked for tampering.
+    This assumes the data reduction proxy injected fingerprints have not been
+    tampered with. Only the data reduction proxy responses with 200 OK response
+    code are checked.
+  </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.HeaderTamperedHTTP">
+  <owner>xingx@chromium.org</owner>
+  <owner>bolian@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The total number of HTTP responses that some part (specified by suffix name)
+    have been tampered with. This assumes the data reduction proxy injected
+    fingerprints have not been tampered with. Only the data reduction proxy
+    responses with 200 OK response code are checked.
+  </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.HeaderTamperedHTTPS">
+  <owner>xingx@chromium.org</owner>
+  <owner>bolian@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The total number of HTTPS responses that some part (specified by suffix
+    name) have been tampered with. This assumes the data reduction proxy
+    injected fingerprints have not been tampered with. Only the data reduction
+    proxy responses with 200 OK response code are checked.
+  </summary>
+</histogram>
+
 <histogram name="DataReductionProxy.NetworkChangeEvents"
     enum="DataReductionProxyNetworkChangeEvent">
   <owner>bengr@chromium.org</owner>
@@ -49611,6 +49683,61 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <affected-histogram name="Cros.ClickOnShelf"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DifferentTamperDetectionFingerprints" separator="_">
+  <suffix name="ChromeProxy"
+      label="for each carrier, number of tamperings detected on Chrome-Proxy
+             header"/>
+  <suffix name="ChromeProxy_Total"
+      label="total number of tamperings detected on Chrome-Proxy header"/>
+  <suffix name="ContentLength"
+      label="for each carrier, total number of responses whose Content-Length
+             header has been tampered with"/>
+  <suffix name="ContentLength_Total"
+      label="total number of responses whose Chrome-Proxy header has been
+             tampered with"/>
+  <suffix name="ContentLength_CSS"
+      label="for each carrier, number of CSS responses whose Content-Length
+             header has been tampered with"/>
+  <suffix name="ContentLength_CSS_Total"
+      label="total number of CSS responses whose Content-Length header has
+             been tampered with"/>
+  <suffix name="ContentLength_Image"
+      label="for each carrier, number of image responses whose Content-Length
+             header has been tampered with"/>
+  <suffix name="ContentLength_Image_Total"
+      label="total number of image responses whose Content-Length header has
+             been tampered with"/>
+  <suffix name="ContentLength_JS"
+      label="for each carrier, number of JavaScript responses whose
+             Content-Length header has been tampered with"/>
+  <suffix name="ContentLength_JS_Total"
+      label="total number of JavaScript responses whose Content-Length header
+             has been tampered with"/>
+  <suffix name="ContentLength_Other"
+      label="for each carrier, number of other type responses whose
+             Content-Length header has been tampered with"/>
+  <suffix name="ContentLength_Other_Total"

[Alexei Svitkine (slow), 2014/08/05 15:24:10]

If you add a separate histogram_suffixes tag for _Total, then you can simply
list DataReductionProxy.HeaderTamperedHTTP_ContentLength there and same for
others, rather than having everything here.

[xingx1, 2014/08/05 18:08:50]

Done.

+      label="total number of other type responses whose Content-Length header
+             has been tampered with"/>
+  <suffix name="OtherHeaders"
+      label="for each carrier, number of tamperings detected on a list of
+             headers"/>
+  <suffix name="OtherHeaders_Total"
+      label="total number of tamperings detected on a list of headers"/>
+  <suffix name="Via"
+      label="for each carrier, number of tamperings detected on Via header"/>
+  <suffix name="Via_Total"
+      label="total number of tamperings detected on Via header"/>
+  <suffix name="Via_Missing"
+      label="for each carrier, number of responses whose data reduction
+             proxy's Via header is missing"/>
+  <suffix name="Via_Missing_Total"
+      label="total number of responses whose data reduction proxy's Via
+             header is missing"/>
+  <affected-histogram name="DataReductionProxy.HeaderTamperedHTTP"/>
+  <affected-histogram name="DataReductionProxy.HeaderTamperedHTTPS"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DiskUsagePerUserCount" separator=".">
   <suffix name="1User" label="Only 1 user exists on device."/>
   <suffix name="2Users" label="2 users exist on device."/>