Chrome Participated Tamper Detect

components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/common/data_reduction_proxy_headers.h"
 
 #include <string>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/proxy/proxy_service.h"
 
 using base::StringPiece;
 using base::TimeDelta;
 using net::ProxyService;
 
 namespace data_reduction_proxy {
 
+const char* kDataReductionProxyViaValues[] = {"Chrome-Compression-Proxy",

[bengr, 2014/07/11 18:22:49]

I don't know why you added this here, but make these:

const char* const kDataReductionProxyViaValues[] = {
    "Chrome-Compression-Proxy",
    "Chrome Compression Proxy"
};

[bengr, 2014/07/11 18:22:49]

Also, move this into an anonymous namespace.

+                                              "Chrome Compression Proxy"};
+
 bool GetDataReductionProxyBypassDuration(
     const net::HttpResponseHeaders* headers,
     const std::string& action_prefix,
     base::TimeDelta* duration) {
   void* iter = NULL;
   std::string value;
   std::string name = "chrome-proxy";
 
   while (headers->EnumerateHeader(&iter, name, &value)) {
     if (value.size() > action_prefix.size()) {
@@ skipping 38 matching lines @@
   // Next, look for 'bypass'.
   if (GetDataReductionProxyBypassDuration(
       headers, "bypass=", &proxy_info->bypass_duration)) {
     return true;
   }
   return false;
 }
 
 bool HasDataReductionProxyViaHeader(const net::HttpResponseHeaders* headers) {
   const size_t kVersionSize = 4;
-  const char kDataReductionProxyViaValue[] = "Chrome-Compression-Proxy";
-  size_t value_len = strlen(kDataReductionProxyViaValue);
+  size_t value_len = strlen(kDataReductionProxyViaValues[0]);
   void* iter = NULL;
   std::string value;
 
   // Case-sensitive comparison of |value|. Assumes the received protocol and the
   // space following it are always |kVersionSize| characters. E.g.,
   // 'Via: 1.1 Chrome-Compression-Proxy'
   while (headers->EnumerateHeader(&iter, "via", &value)) {
     if (value.size() >= kVersionSize + value_len &&
-        !value.compare(kVersionSize, value_len, kDataReductionProxyViaValue))
+        !value.compare(kVersionSize, value_len,
+                       kDataReductionProxyViaValues[0]))
       return true;
   }
 
   // TODO(bengr): Remove deprecated header value.
   const char kDeprecatedDataReductionProxyViaValue[] =
       "1.1 Chrome Compression Proxy";

[bengr, 2014/07/11 18:22:49]

This should be changed too.

   iter = NULL;
   while (headers->EnumerateHeader(&iter, "via", &value))
     if (value == kDeprecatedDataReductionProxyViaValue)
       return true;
 
   return false;
 }
 
 net::ProxyService::DataReductionProxyBypassEventType
 GetDataReductionProxyBypassEventType(
@@ skipping 26 matching lines @@
         headers->response_code() < net::HTTP_INTERNAL_SERVER_ERROR) {
       return ProxyService::PROXY_4XX_BYPASS;
     }
     return ProxyService::MISSING_VIA_HEADER;
   }
   // There is no bypass event.
   return ProxyService::BYPASS_EVENT_TYPE_MAX;
 }
 
 }  // namespace data_reduction_proxy