Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 338473003: Remove media_galleries_handlers - not used. (Closed)

Created:
6 years, 6 months ago by vandebo (ex-Chrome)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, Lei Zhang, tommycli, Greg Billock, chromium-apps-reviews_chromium.org, hirono
Project:
chromium
Visibility:
Public.

Description

Remove media_galleries_handlers - not used. According to crbug.com/307827 - the code that used media_galleries_handlers has been removed. BUG=NONE NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277773

Patch Set 1 #

Patch Set 2 : Remove manfiest bits as well #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -333 lines) Patch
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.h View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 1 2 2 chunks +0 lines, -52 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/media_galleries_private.idl View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/common/extensions/api/media_galleries_private/media_galleries_handler.h View 1 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/common/extensions/api/media_galleries_private/media_galleries_handler.cc View 1 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_l10n_util.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
vandebo (ex-Chrome)
6 years, 6 months ago (2014-06-16 19:26:33 UTC) #1
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-16 19:31:30 UTC) #2
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 19:32:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/338473003/1
6 years, 6 months ago (2014-06-16 19:35:58 UTC) #4
Alexei Svitkine (slow)
histograms lgtm
6 years, 6 months ago (2014-06-16 19:54:37 UTC) #5
vandebo (ex-Chrome)
The CQ bit was unchecked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 20:05:00 UTC) #6
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 20:05:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/338473003/1
6 years, 6 months ago (2014-06-16 20:07:58 UTC) #8
vandebo (ex-Chrome)
The CQ bit was unchecked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 21:27:32 UTC) #9
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 21:27:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/338473003/1
6 years, 6 months ago (2014-06-16 21:29:39 UTC) #11
vandebo (ex-Chrome)
The CQ bit was unchecked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 21:58:19 UTC) #12
vandebo (ex-Chrome)
Actually, there's a bit more code to remove. +kalman@ for extensions bits (PS1 PS2 delta)
6 years, 6 months ago (2014-06-16 22:05:42 UTC) #13
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-16 22:08:46 UTC) #14
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-16 22:10:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/338473003/40001
6 years, 6 months ago (2014-06-16 22:12:37 UTC) #16
mtomasz
On 2014/06/16 22:12:37, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-17 02:46:02 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 07:10:45 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74144)
6 years, 6 months ago (2014-06-17 07:10:46 UTC) #19
vandebo (ex-Chrome)
Added NOTRY=true to skip incorrect presubmit checks.
6 years, 6 months ago (2014-06-17 15:35:03 UTC) #20
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-17 15:35:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/338473003/40001
6 years, 6 months ago (2014-06-17 15:36:59 UTC) #22
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 15:38:30 UTC) #23
Message was sent while issue was closed. 
Change committed as 277773

Powered by Google App Engine
This is Rietveld 408576698