Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 338463002: Add WTF_EXPORT to BitVector::OutOfLineBits (Closed)

Created:
6 years, 6 months ago by hans
Modified:
6 years, 6 months ago
Reviewers:
Reid Kleckner, Nico
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add WTF_EXPORT to BitVector::OutOfLineBits dllexport/dllimport aren't inherited by nested classes like visibility attributes are on Posix, and this class has some non-inline methods that need to get exported. For example, if ~BitVector gets inlined, we might try calling OutOfLineBits::destroy across a dll boundry. BUG=82385 TEST=attempt to build blink_web.dll with Clang on Windows Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/wtf/BitVector.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
Please take a look.
6 years, 6 months ago (2014-06-12 20:05:42 UTC) #1
Nico
lgtm Does msvs have ways to force things to be inlined? If so, could you ...
6 years, 6 months ago (2014-06-12 20:39:19 UTC) #2
Reid Kleckner
Yes, there is __forceinline, but you have to build with optimizations for it to work. ...
6 years, 6 months ago (2014-06-12 20:50:06 UTC) #3
hans
The CQ bit was checked by hans@chromium.org
6 years, 6 months ago (2014-06-12 21:02:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/338463002/1
6 years, 6 months ago (2014-06-12 21:03:39 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 23:44:16 UTC) #6
Message was sent while issue was closed.
Change committed as 176061

Powered by Google App Engine
This is Rietveld 408576698