Add back button to chrome://devices

Add back button to chrome://devices

When settings in a window is enabled, add a back button to the devices
page. This helps because the window has no address bar. See bug for
screenshot.

Longer-term, the devices page should show as an overlay in Settings
rather than load as a new page.

RTL is not enabled for this page; see issue 386020.

BUG=384333
R=noamsml@chromium.org,oshima@chromium.org

+oshima@ for icon. Oshima, is theme_resources the right place for this?
+stevenjb@ for browser shenanigans in local_discovery_ui.cc.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278376

[oshima, 2014-06-18 05:45:04]

is this cros only? (if so, the right place is cros/)

[stevenjb, 2014-06-18 17:40:00]

This is not cros specific, --enable-settings-window is available on other
platforms, it's just enabled by default only on cros.

https://codereview.chromium.org/338423005/diff/1/chrome/browser/ui/webui/loca...
File chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc (right):

https://codereview.chromium.org/338423005/diff/1/chrome/browser/ui/webui/loca...
chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc:124:
!browser->CanSupportWindowFeature(Browser::FEATURE_LOCATIONBAR)) {
You should be able to test browser->is_trusted_source() instead, which is a
better indicator. If that doesn't work, talk to me.

[Noam Samuel, 2014-06-18 17:57:04]

lgtm

[michaelpg, 2014-06-18 18:56:37]

https://codereview.chromium.org/338423005/diff/1/chrome/browser/ui/webui/loca...
File chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc (right):

https://codereview.chromium.org/338423005/diff/1/chrome/browser/ui/webui/loca...
chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc:124:
!browser->CanSupportWindowFeature(Browser::FEATURE_LOCATIONBAR)) {
On 2014/06/18 17:40:00, stevenjb wrote:
> You should be able to test browser->is_trusted_source() instead, which is a
> better indicator. If that doesn't work, talk to me.

Yes, that's better.

[oshima, 2014-06-18 20:52:42]

ok, c/a/theme lgtm

[michaelpg, 2014-06-19 00:20:54]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-06-19 00:22:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/338423005/20001

[commit-bot: I haz the power, 2014-06-19 06:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 06:33:05]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18821)

[michaelpg, 2014-06-19 07:32:58]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-06-19 07:34:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/338423005/40001

[commit-bot: I haz the power, 2014-06-19 15:09:07]

Change committed as 278376