Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 3384003: Made predata smaller by storing symbol data in variable length base-128. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Made predata smaller by storing symbol data in variable length base-128. Remove position from symbol data - they must come in the correct order anyway.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -68 lines) Patch
M src/parser.h View 1 6 chunks +26 lines, -26 lines 0 comments Download
M src/parser.cc View 1 15 chunks +92 lines, -42 lines 0 comments Download
M src/utils.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
10 years, 3 months ago (2010-09-14 13:05:48 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/3384003/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3384003/diff/1/2#newcode1663 src/parser.cc:1663: symbol_id = Will fit on one line now. ...
10 years, 3 months ago (2010-09-15 07:20:51 UTC) #2
Lasse Reichstein
10 years, 3 months ago (2010-09-15 10:54:05 UTC) #3
http://codereview.chromium.org/3384003/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/3384003/diff/1/2#newcode1663
src/parser.cc:1663: symbol_id =
Done.

http://codereview.chromium.org/3384003/diff/1/2#newcode5514
src/parser.cc:5514: symbol_data_ =
Done.

http://codereview.chromium.org/3384003/diff/1/3
File src/parser.h (right):

http://codereview.chromium.org/3384003/diff/1/3#newcode140
src/parser.h:140: // of unsigned ints (for function entries)/bytes (for symbol
ids).
Reworded.

Powered by Google App Engine
This is Rietveld 408576698