Issue 338383003: Revert of aura: Enables --enable-text-input-focus-manager by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338383003: Revert of aura: Enables --enable-text-input-focus-manager by default. (Closed)

Created:
6 years, 6 months ago by ckocagil

Modified:
6 years, 6 months ago

Reviewers:
msw, sky, Yuki

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of aura: Enables --enable-text-input-focus-manager by default. (https://codereview.chromium.org/323983005/) Reason for revert: Suspected of breaking interactive_ui_tests on Win: http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28dbg%29/builds/48698 Original issue's description: > aura: Enables --enable-text-input-focus-manager by default. > > This CL enables the experimental text input focus manager by default. > > BUG=290701 > R=msw@chromium.org, sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278879 TBR=msw@chromium.org,sky@chromium.org,yukishiino@chromium.org NOTREECHECKS=true NOTRY=true BUG=290701 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278952

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/base/ui_base_switches_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

ckocagil

Created Revert of aura: Enables --enable-text-input-focus-manager by default.

6 years, 6 months ago (2014-06-21 13:06:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/338383003/1

6 years, 6 months ago (2014-06-21 13:07:53 UTC) #2

msw

6 years, 6 months ago (2014-06-23 17:13:47 UTC) #4

Message was sent while issue was closed.

lgtm; the bot went green with the revert:
http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28db...