Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 338373005: Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@refactor-webmidi-initialization
Visibility:
Public.

Description

Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (https://codereview.chromium.org/311733004/) Reason for revert: FAILED: /mnt/data/b/build/goma/gomacc c++ -MMD -MF obj/third_party/WebKit/Source/bindings/v8/webcore_generated.ScriptPromiseResolverWithContext.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DGL_GLEXT_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_SVG_FONTS=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DENABLE_OPENTYPE_VERTICAL=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_DEVICE_VIRTUAL_ISOPAQUE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_SETCONFIG -DSK_IGNORE_ETC1_SUPPORT -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/WebKit/Source -Igen/blink/core -Igen/blink/modules -Igen/blink/platform -Igen/blink/bindings/core/v8 -Igen/blink/bindings/modules/v8 -Igen/blink -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/angle/include -I../../third_party/ffmpeg -I../../third_party/WebKit -I../../third_party/ots/include -I../../third_party/zlib -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/libwebp -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -I../../third_party/libxslt -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/qcms/src -I../../third_party/sqlite -I../../v8/include -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -B/mnt/data/b/build/slave/WebKit_Linux/build/src/third_party/binutils/Linux_x64/Release/bin -fno-strict-aliasing -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat -c ../../third_party/WebKit/Source/bindings/v8/ScriptPromiseResolverWithContext.cpp -o obj/third_party/WebKit/Source/bindings/v8/webcore_generated.ScriptPromiseResolverWithContext.o ../../third_party/WebKit/Source/bindings/v8/ScriptPromiseResolverWithContext.cpp: In constructor 'WebCore::ScriptPromiseResolverWithContext::ScriptPromiseResolverWithContext(WebCore::ScriptState*, WebCore::ScriptPromiseResolverWithContext::Mode)': ../../third_party/WebKit/Source/bindings/v8/ScriptPromiseResolverWithContext.cpp:23:34:error: 'relaxAdoptionRequirement' was not declared in this scope ninja: build stopped: subcommand failed. Original issue's description: > Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. > > Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer". > The initializer should stay alive until the initialization succeeds (i.e. the > associated Promise is resolved), the initialization fails > (i.e. rejected), or the associated ExecutionContext is stopped. > This CL introduces the the constructor mode ScriptPromiseResolverWithContext. > If KeepAliveWhilePending is specified, the created resolver stays alive while > one of the above conditions meets. > Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext. > > This CL rewrites WebMIDI and WebCrypto async operations with it. > > BUG=361041 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -216 lines) Patch
M Source/bindings/v8/ScriptPromiseResolverWithContext.h View 4 chunks +3 lines, -18 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverWithContext.cpp View 3 chunks +3 lines, -28 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.cpp View 3 chunks +138 lines, -58 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 3 chunks +15 lines, -11 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 3 chunks +34 lines, -14 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.h View 2 chunks +24 lines, -30 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.cpp View 2 chunks +97 lines, -52 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
Created Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext.
6 years, 6 months ago (2014-06-18 04:13:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/338373005/1
6 years, 6 months ago (2014-06-18 04:14:02 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 04:14:03 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-18 04:14:04 UTC) #4
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 6 months ago (2014-06-18 04:14:05 UTC) #5
jamesr
6 years, 6 months ago (2014-06-18 04:14:12 UTC) #6
On 2014/06/18 04:13:30, jamesr wrote:
> Created Revert of Introduce KeepAliveWhilePending to
> ScriptPromiseResolverWithContext.

yhirano@ is too fast for me!

Powered by Google App Engine
This is Rietveld 408576698