Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 338373004: Smoother full-screen UX (Closed)

Created:
6 years, 6 months ago by Jamie
Modified:
6 years, 6 months ago
Reviewers:
weitao, garykac, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

We hook onMaximized so that if the user maximizes the window, it automatically full-screens. This allows us to get the same behaviour if the user double-clicks the title bar or uses some other OS shortcut to maximize the window as we get if they clicks the maximize button. However, it's not a particularly clean transition to full-screen mode, especially on Mac, and I suspect it's the root cause of the referenced bug (though I can't repro it). This CL simplifies the common case of maximizing via the window control, which gives a much smoother UX. BUG=384678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278199

Patch Set 1 #

Patch Set 2 : Reinstate double-restore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M remoting/webapp/window_frame.js View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Jamie
ptal
6 years, 6 months ago (2014-06-18 00:48:59 UTC) #1
Jamie
Please CQ when ready.
6 years, 6 months ago (2014-06-18 01:01:11 UTC) #2
kelvinp
lgtm
6 years, 6 months ago (2014-06-18 06:00:56 UTC) #3
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 6 months ago (2014-06-18 06:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/338373004/20001
6 years, 6 months ago (2014-06-18 06:03:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 06:03:05 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-18 06:03:05 UTC) #7
Jamie
Can I get a committer LGTM please?
6 years, 6 months ago (2014-06-18 16:52:45 UTC) #8
weitao
On 2014/06/18 16:52:45, Jamie wrote: > Can I get a committer LGTM please? LGTM
6 years, 6 months ago (2014-06-18 16:58:27 UTC) #9
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 6 months ago (2014-06-18 17:10:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/338373004/20001
6 years, 6 months ago (2014-06-18 17:10:44 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 23:55:09 UTC) #12
Message was sent while issue was closed.
Change committed as 278199

Powered by Google App Engine
This is Rietveld 408576698