Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 338363004: Remove Profile* from TemplateURL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index a9f27dba9e41f8254083d0febee3a65f736a5db6..68348c6aeb26ffa62600c4b780d53d20c1b289f3 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -248,12 +248,12 @@ class OmniboxViewTest : public InProcessBrowserTest,
data.short_name = ASCIIToUTF16(kSearchShortName);
data.SetKeyword(ASCIIToUTF16(kSearchKeyword));
data.SetURL(kSearchURL);
- TemplateURL* template_url = new TemplateURL(profile, data);
+ TemplateURL* template_url = new TemplateURL(data);
model->Add(template_url);
model->SetUserSelectedDefaultSearchProvider(template_url);
data.SetKeyword(ASCIIToUTF16(kSearchKeyword2));
- model->Add(new TemplateURL(profile, data));
+ model->Add(new TemplateURL(data));
// Remove built-in template urls, like google.com, bing.com etc., as they
// may appear as autocomplete suggests and interfere with our tests.
@@ -597,7 +597,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DesiredTLDWithTemporaryText) {
data.short_name = ASCIIToUTF16("abc");
data.SetKeyword(ASCIIToUTF16(kSearchText));
data.SetURL("http://abc.com/");
- template_url_service->Add(new TemplateURL(profile, data));
+ template_url_service->Add(new TemplateURL(data));
// Send "ab", so that an "abc" entry appears in the popup.
const wchar_t kSearchTextPrefixKeys[] = { ui::VKEY_A, ui::VKEY_B, 0 };
@@ -1019,7 +1019,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_NonSubstitutingKeywordTest) {
data.short_name = ASCIIToUTF16("Search abc");
data.SetKeyword(ASCIIToUTF16(kSearchText));
data.SetURL("http://abc.com/{searchTerms}");
- TemplateURL* template_url = new TemplateURL(profile, data);
+ TemplateURL* template_url = new TemplateURL(data);
template_url_service->Add(template_url);
omnibox_view->SetUserText(base::string16());
@@ -1043,7 +1043,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_NonSubstitutingKeywordTest) {
template_url_service->Remove(template_url);
data.short_name = ASCIIToUTF16("abc");
data.SetURL("http://abc.com/");
- template_url_service->Add(new TemplateURL(profile, data));
+ template_url_service->Add(new TemplateURL(data));
// We always allow exact matches for non-substituting keywords.
ASSERT_NO_FATAL_FAILURE(SendKeySequence(kSearchTextKeys));

Powered by Google App Engine
This is Rietveld 408576698