components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java - Issue 338363003: Push API: register PushMessagingServiceImpl as GCMAppHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

Issue 338363003: Push API: register PushMessagingServiceImpl as GCMAppHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add missing const on CanHandle. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/push_messaging_service_impl.cc ('K') | « chrome/common/pref_names.cc ('k') | components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

diff --git a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

index 932d47a879d6fea7608552914ad80521e1b348c2..8d21b2876435f26e9fc2f3dcb0ea2964022dd2d4 100644

--- a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

+++ b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

@@ -229,9 +229,6 @@ public class GCMDriver {

try {

final int MAX_RENDERERS = 1;

BrowserStartupController.get(context).startBrowserProcessesSync(MAX_RENDERERS);

- // TODO(johnme): Explicitly call a JNI method that starts up GCMDriver,

- // rather than relying on it being started automatically by

- // ProfileSyncServiceFactory::BuildServiceInstanceFor.

if (sInstance != null) {

task.run();

} else {