Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 338353009: Disable SSE4 procs until Valgrind's sorted out. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
Stephen White, mtklein
CC:
reviews_skia.org, henrik.smiding
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Disable SSE4 procs until Valgrind's sorted out. BUG=skia:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/opts/opts_check_x86.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein_C
6 years, 6 months ago (2014-06-17 23:11:14 UTC) #1
Stephen White
LGTM. (Hopefully this isn't a bug in Valgrind's understanding of SSE4...)
6 years, 6 months ago (2014-06-17 23:12:53 UTC) #2
mtklein
On 2014/06/17 23:12:53, Stephen White wrote: > LGTM. (Hopefully this isn't a bug in Valgrind's ...
6 years, 6 months ago (2014-06-17 23:26:18 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-17 23:26:21 UTC) #4
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 6 months ago (2014-06-17 23:42:18 UTC) #5
mtklein
lgtm
6 years, 6 months ago (2014-06-17 23:42:33 UTC) #6
mtklein
6 years, 6 months ago (2014-06-18 00:31:31 UTC) #7
The CQ bit was unchecked by mtklein@google.com

Powered by Google App Engine
This is Rietveld 408576698