ppapi/native_client/src/trusted/plugin/plugin.h - Issue 338353008: NaCl: clean up nexe loading logic in trusted plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 338353008: NaCl: clean up nexe loading logic in trusted plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/nacl/nacl_browsertest.cc ('k') | ppapi/native_client/src/trusted/plugin/plugin.cc » ('j') | ppapi/native_client/src/trusted/plugin/plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/trusted/plugin/plugin.h

diff --git a/ppapi/native_client/src/trusted/plugin/plugin.h b/ppapi/native_client/src/trusted/plugin/plugin.h

index 74ec1a8f15b830a03eda42bd6185c2b1e5b33993..4b576802bb620af539d700c2fea21beee8dac346 100644

--- a/ppapi/native_client/src/trusted/plugin/plugin.h

+++ b/ppapi/native_client/src/trusted/plugin/plugin.h

@@ -160,17 +160,10 @@ class Plugin : public pp::Instance {

bool* started,

ServiceRuntime* service_runtime);

- // Signals that the nexe is started.

- // This is invoked on the main thread.

- void SignalNexeStarted(int32_t pp_error,

- bool* started,

- ServiceRuntime* service_runtime);

// This is invoked on the main thread.

void LoadNexeAndStart(int32_t pp_error,

ServiceRuntime* service_runtime,

- PP_NaClFileInfo file_info,

- const pp::CompletionCallback& callback);

+ PP_NaClFileInfo file_info);

// Callback used when getting the URL for the .nexe file. If the URL loading

// is successful, the file descriptor is opened and can be passed to sel_ldr