content/browser/shared_worker/shared_worker_service_impl.cc - Issue 338353007: Implementation of shared worker code path for WebView file system permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.cc

Issue 338353007: Implementation of shared worker code path for WebView file system permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_sharedworker

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/shared_worker/shared_worker_host.cc ('K') | « content/browser/shared_worker/shared_worker_service_impl.h ('k') | content/browser/worker_host/worker_process_host.h » ('j') | content/browser/worker_host/worker_process_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/shared_worker_service_impl.cc

diff --git a/content/browser/shared_worker/shared_worker_service_impl.cc b/content/browser/shared_worker/shared_worker_service_impl.cc

index 4a689fa812fe422e522ffe3193c8d6f5394b7e7f..7c2344f7c3bd4a272ac347fd1991eee2bea41fd7 100644

--- a/content/browser/shared_worker/shared_worker_service_impl.cc

+++ b/content/browser/shared_worker/shared_worker_service_impl.cc

@@ -391,13 +391,13 @@ void SharedWorkerServiceImpl::AllowDatabase(

host->AllowDatabase(url, name, display_name, estimated_size, result);

}

-void SharedWorkerServiceImpl::AllowFileSystem(

+void SharedWorkerServiceImpl::RequestFileSystemAccessSync(

int worker_route_id,

const GURL& url,

- bool* result,

+ IPC::Message* reply_msg,

SharedWorkerMessageFilter* filter) {

if (SharedWorkerHost* host = FindSharedWorkerHost(filter, worker_route_id))

- host->AllowFileSystem(url, result);

+ host->RequestFileSystemAccessSync(url, reply_msg);

Andrew T Wilson (Slow) 2014/06/20 22:04:27 What happens to reply_msg if we can't find the sha

Xi Han 2014/06/23 20:43:34 Change the code to send the reply_msg directly if

}

void SharedWorkerServiceImpl::AllowIndexedDB(