chrome/browser/guest_view/web_view/web_view_guest.h - Issue 338353007: Implementation of shared worker code path for WebView file system permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 338353007: Implementation of shared worker code path for WebView file system permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_sharedworker

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('j') | content/browser/shared_worker/shared_worker_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/web_view_guest.h

diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h

index 32defb5c87197e7ad491a23e44485151e5cb52e2..64517b2845954075ed6352547ea637ac38fa6014 100644

--- a/chrome/browser/guest_view/web_view/web_view_guest.h

+++ b/chrome/browser/guest_view/web_view/web_view_guest.h

@@ -274,7 +274,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,

int render_frame_id,

const GURL& url,

bool blocked_by_policy,

- IPC::Message* reply_msg);

+ base::Callback<void(bool)> callback);

private:

virtual ~WebViewGuest();

@@ -336,11 +336,12 @@ class WebViewGuest : public GuestView<WebViewGuest>,

const GURL& url,

bool allowed);

- static void FileSystemAccessedSyncResponse(int render_process_id,

- int render_frame_id,

- const GURL& url,

- IPC::Message* reply_msg,

- bool allowed);

+ static void FileSystemAccessedSyncResponse(

+ int render_process_id,

+ int render_frame_id,

+ const GURL& url,

+ base::Callback<void(bool)> callback,

+ bool allowed);

// WebContentsObserver implementation.

virtual void DidCommitProvisionalLoadForFrame(