content/public/browser/content_browser_client.h - Issue 338353007: Implementation of shared worker code path for WebView file system permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 338353007: Implementation of shared worker code path for WebView file system permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_sharedworker

Patch Set: Use scoped_refptr. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/shared_worker/shared_worker_service_impl.cc ('K') | « content/browser/worker_host/worker_process_host.cc ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index 739f4c0ff75af62c174a2946713df93deca519bb..807a25f1fbafc2cf96657d9255f90ba5aef16f9c 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -317,10 +317,11 @@ class CONTENT_EXPORT ContentBrowserClient {

// Allow the embedder to control if access to file system by a shared worker

// is allowed.

// This is called on the IO thread.

- virtual bool AllowWorkerFileSystem(

+ virtual void RequestWorkerFileSystemAccess(

jabdelmalek 2014/06/24 21:23:32 nit: keep the old name. The "Allow" is used by con

Xi Han 2014/06/25 14:50:26 Done.

const GURL& url,

ResourceContext* context,

- const std::vector<std::pair<int, int> >& render_frames);

+ const std::vector<std::pair<int, int> >& render_frames,

+ base::Callback<void(bool)> callback);

// Allow the embedder to control if access to IndexedDB by a shared worker

// is allowed.