Implementation of shared worker code path for WebView file system permission.

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 327 matching lines @@
       const GURL& url,
       const base::string16& name,
       const base::string16& display_name,
       unsigned long estimated_size,
       ResourceContext* context,
       const std::vector<std::pair<int, int> >& render_frames);
 
   // Allow the embedder to control if access to file system by a shared worker
   // is allowed.
   // This is called on the IO thread.
-  virtual bool AllowWorkerFileSystem(
+  virtual void RequestWorkerFileSystemAccessSync(

[Andrew T Wilson (Slow), 2014/06/20 22:04:27]

Why is this called ...AccessSync() - I'm assuming since you have a callback,
this is an Async call?

[Xi Han, 2014/06/23 02:51:13]

Sorry for the confusion. But this is a sync call, with delay reply. Initially we
implemented it in the way that we did for the Worker: just carry this IPC
reply_msg to the end, and write the result to it and send it. However, the
difficulty that we meet is that we have no way to send a IPC msg in both
aw_content_browser_client.cc and content_browser_client.cc, which need to give
default reply to the IPC msg (true or false). So we adopt the way to pass in a
callback, rather than IPC::Message* reply_msg. So aw_content_browser_client.cc
and content_browser_client.cc only need to give their own default replies, and
the worker_process_host.cc who passes the message will be responsible to send
the reply msg. 

Hope my explanation will help here. If you think the name is still confusing, we
can remove the Sync sufix and just use "RequestWorkerFileSystem". What do you
think?

[jam, 2014/06/23 07:02:00]

What does this line mean? If there's a delay reply, you mean the callback is
called back after this method returns right? if so it's async. that's how
chrome's implementation is done right now.

[Xi Han, 2014/06/23 20:43:34]

I see. Thank you for the explanation. All of the "sync" suffix are removed.

       const GURL& url,
       ResourceContext* context,
-      const std::vector<std::pair<int, int> >& render_frames);
+      const std::vector<std::pair<int, int> >& render_frames,
+      base::Callback<void(bool)> callback);
 
   // Allow the embedder to control if access to IndexedDB by a shared worker
   // is allowed.
   // This is called on the IO thread.
   virtual bool AllowWorkerIndexedDB(
       const GURL& url,
       const base::string16& name,
       ResourceContext* context,
       const std::vector<std::pair<int, int> >& render_frames);
 
@@ skipping 313 matching lines @@
   // Allows an embedder to provide its own ExternalVideoSurfaceContainer
   // implementation.  Return NULL to disable external surface video.
   virtual ExternalVideoSurfaceContainer*
   OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_