Implementation of shared worker code path for WebView file system permission.

chrome/browser/guest_view/web_view/web_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 917 matching lines @@
       content::StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL,
       GURL(),
       content::StoragePartition::OriginMatcherFunction(),
       remove_since,
       base::Time::Now(),
       callback);
   return true;
 }
 
 // static
-void WebViewGuest::FileSystemAccessedAsync(int render_process_id,
-                                           int render_frame_id,
-                                           int request_id,
-                                           const GURL& url,
-                                           bool blocked_by_policy) {
+void WebViewGuest::FileSystemAccessed(int render_process_id,
+                                      int render_frame_id,
+                                      const GURL& url,
+                                      bool blocked_by_policy,
+                                      base::Callback<void(bool)> callback) {
   WebViewGuest* guest =
       WebViewGuest::FromFrameID(render_process_id, render_frame_id);
   DCHECK(guest);
   guest->RequestFileSystemPermission(
       url,
       !blocked_by_policy,
-      base::Bind(&WebViewGuest::FileSystemAccessedAsyncResponse,
+      base::Bind(&WebViewGuest::FileSystemAccessedResponse,
                  render_process_id,
                  render_frame_id,
-                 request_id,
-                 url));
+                 url,
+                 callback));
 }
 
 // static
-void WebViewGuest::FileSystemAccessedAsyncResponse(int render_process_id,
-                                                   int render_frame_id,
-                                                   int request_id,
-                                                   const GURL& url,
-                                                   bool allowed) {
+void WebViewGuest::FileSystemAccessedResponse(
+    int render_process_id,
+    int render_frame_id,
+    const GURL& url,
+    base::Callback<void(bool)> callback,
+    bool allowed) {
   TabSpecificContentSettings::FileSystemAccessed(
       render_process_id, render_frame_id, url, !allowed);
-  content::RenderFrameHost* render_frame_host =
-      content::RenderFrameHost::FromID(render_process_id, render_frame_id);
-  if (!render_frame_host)
-    return;
-  render_frame_host->Send(
-      new ChromeViewMsg_RequestFileSystemAccessAsyncResponse(
-          render_frame_id, request_id, allowed));
+  callback.Run(allowed);

[Fady Samuel, 2014/07/08 14:42:46]

attached() && allowed

[Xi Han, 2014/07/08 21:28:24]

The attached() && allowed is done in
WebViewGuest::OnWebViewFileSystemPermissionResponse. This callback is a
different one, which sends a reply message.

 }
 
 // static
-void WebViewGuest::FileSystemAccessedSync(int render_process_id,
-                                          int render_frame_id,
-                                          const GURL& url,
-                                          bool blocked_by_policy,
-                                          IPC::Message* reply_msg) {
+void WebViewGuest::RequestFileSystemAccessPermission(

[Fady Samuel, 2014/07/08 14:42:46]

RequestFileSystemPermissionFromIOThread

Do the thread hop here.

[Xi Han, 2014/07/08 21:28:24]

Done.

+    int render_process_id,
+    int render_frame_id,
+    const GURL& url,
+    bool blocked_by_policy,

[Fady Samuel, 2014/07/08 14:42:46]

Can we reduce "blocked_by_policy"? Replace instances of blocked_by_policy with
allow in WebViewGuest.

[Xi Han, 2014/07/08 21:28:24]

Done.

+    base::Callback<void(bool)> callback) {
   WebViewGuest* guest =
       WebViewGuest::FromFrameID(render_process_id, render_frame_id);
   DCHECK(guest);
   guest->RequestFileSystemPermission(
       url,
       !blocked_by_policy,
-      base::Bind(&WebViewGuest::FileSystemAccessedSyncResponse,
-                 render_process_id,
-                 render_frame_id,
-                 url,
-                 reply_msg));
-}
-
-// static
-void WebViewGuest::FileSystemAccessedSyncResponse(int render_process_id,
-                                                  int render_frame_id,
-                                                  const GURL& url,
-                                                  IPC::Message* reply_msg,
-                                                  bool allowed) {
-  TabSpecificContentSettings::FileSystemAccessed(
-      render_process_id, render_frame_id, url, !allowed);
-  ChromeViewHostMsg_RequestFileSystemAccessSync::WriteReplyParams(reply_msg,
-                                                                  allowed);
-  content::RenderFrameHost* render_frame_host =
-      content::RenderFrameHost::FromID(render_process_id, render_frame_id);
-  if (!render_frame_id)
-    return;
-  render_frame_host->Send(reply_msg);
+      callback);
 }
 
 WebViewGuest::~WebViewGuest() {
 }
 
 void WebViewGuest::DidCommitProvisionalLoadForFrame(
     content::RenderFrameHost* render_frame_host,
     const GURL& url,
     content::PageTransition transition_type) {
   find_helper_.CancelAllFindSessions();
@@ skipping 629 matching lines @@
     bool allow,
     const std::string& user_input) {
   WebViewGuest* guest =
       WebViewGuest::From(embedder_render_process_id(), new_window_instance_id);
   if (!guest)
     return;
 
   if (!allow)
     guest->Destroy();
 }