Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: mojo/services/view_manager/view_manager_unittest.cc

Issue 338353006: Changes routing of input events in view manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/view_manager/view_manager_unittest.cc
diff --git a/mojo/services/view_manager/view_manager_unittest.cc b/mojo/services/view_manager/view_manager_unittest.cc
index 112a36fe2bfe0fa1c522cc4f836603c82a4d0a05..6cd00c02e15eb56ef171de876f1209f16d565083 100644
--- a/mojo/services/view_manager/view_manager_unittest.cc
+++ b/mojo/services/view_manager/view_manager_unittest.cc
@@ -64,6 +64,8 @@ class ViewManagerProxy : public TestChangeTracker::Delegate {
return instance;
}
+ ViewManagerService* view_manager() { return view_manager_; }
+
// Runs the main loop until |count| changes have been received.
std::vector<Change> DoRunLoopUntilChangesCount(size_t count) {
DCHECK_EQ(0u, quit_count_);
@@ -291,7 +293,7 @@ class TestViewManagerClientConnection
connection_.set_view_manager(client());
}
- // IViewMangerClient:
+ // ViewMangerClient:
virtual void OnViewManagerConnectionEstablished(
ConnectionSpecificId connection_id,
const String& creator_url,
@@ -343,6 +345,9 @@ class TestViewManagerClientConnection
const Callback<void()>& callback) OVERRIDE {
tracker_.OnViewInputEvent(view_id, event.Pass());
}
+ virtual void DispatchOnViewInputEvent(Id view_id,
+ mojo::EventPtr event) OVERRIDE {
+ }
private:
TestChangeTracker tracker_;
@@ -1329,6 +1334,27 @@ TEST_F(ViewManagerTest, ConnectTwice) {
}
}
+TEST_F(ViewManagerTest, OnViewInput) {
+ // Create node 1 and assign a view from connection 2 to it.
+ ASSERT_TRUE(connection_->CreateNode(BuildNodeId(1, 1)));
+ ASSERT_NO_FATAL_FAILURE(EstablishSecondConnection(false));
+ ASSERT_TRUE(connection2_->CreateView(BuildViewId(2, 11)));
+ ASSERT_TRUE(connection2_->SetView(BuildNodeId(1, 1), BuildViewId(2, 11)));
+
+ // Dispatch an event to the view and verify its received.
+ {
+ EventPtr event(Event::New());
+ event->action = 1;
+ connection_->view_manager()->DispatchOnViewInputEvent(
+ BuildViewId(2, 11),
+ event.Pass());
+ connection2_->DoRunLoopUntilChangesCount(1);
+ const Changes changes(ChangesToDescription1(connection2_->changes()));
+ ASSERT_EQ(1u, changes.size());
+ EXPECT_EQ("InputEvent view=2,11 event_action=1", changes[0]);
+ }
+}
+
// TODO(sky): add coverage of test that destroys connections and ensures other
// connections get deletion notification (or advanced server id).
« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698