Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 338353006: Changes routing of input events in view manager (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Changes routing of input events in view manager Events are now sent to the window manager (assumed to be at connection id 1 for now). The window manager can then do what it wants with them. For now I made it bounce the event back to the server so everything works as it did. Until we get FIFO across pipes I'm putting these messages on the ViewManager/ViewManagerClient interface. That'll change. BUG=384433 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -16 lines) Patch
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/services/view_manager/ids.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 3 chunks +15 lines, -1 line 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 3 chunks +18 lines, -13 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 4 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 6 months ago (2014-06-17 20:00:09 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-17 21:43:13 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-17 21:48:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/338353006/1
6 years, 6 months ago (2014-06-17 21:51:33 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:24:44 UTC) #5
Message was sent while issue was closed.
Change committed as 277982

Powered by Google App Engine
This is Rietveld 408576698