build/android/pylib/gtest/test_package_exe.py - Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/device/device_utils.py ('K') | « build/android/pylib/gtest/test_package_apk.py ('k') | build/android/pylib/linker/test_case.py » ('j') | tools/android/adb_profile_chrome/chrome_controller.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index 252c4a4f08b76562cc8c1160cddfa8617ecb3e94..644ff3f90fddd7dc5a66aabd5ac8add121be31f5 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -77,7 +77,7 @@ class TestPackageExecutable(TestPackage):

#override

def ClearApplicationState(self, device):

- device.old_interface.KillAllBlocking(self.suite_name, 30)

+ device.KillAll(self.suite_name, blocking=True, timeout=30)

#override

def CreateCommandLineFileOnDevice(self, device, test_filter, test_arguments):