tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py - Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: appeasing windows Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

index e73eac149d79307d0554f3137f6c33e75d926b6f..1dd5e6e9e00f5a0d9140cfa869e8fe8f8a966e88 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

@@ -8,6 +8,7 @@ from telemetry.core.backends.chrome import android_browser_finder

from telemetry.core.platform import profiler

from telemetry.util import support_binaries

+from pylib.device import intent

class UnableToFindApplicationException(Exception):

"""Exception when unable to find a launched application"""

@@ -39,9 +40,10 @@ class OOMKillerProfiler(profiler.Profiler):

'org.chromium.memconsumer/.MemConsumer',

'--ei memory 20')

# Bring the browser to the foreground after launching the mem consumer

- self._browser_backend.adb.StartActivity(browser_backend.package,

- browser_backend.activity,

- True)

+ self._browser_backend.adb.device().StartActivity(

+ intent.Intent(package=browser_backend.package,

+ activity=browser_backend.activity),

+ blocking=True)

@classmethod

def name(cls):

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py ('k') | no next file » | no next file with comments »