tools/android/adb_profile_chrome/controllers_unittest.py - Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/controllers_unittest.py

Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: appeasing windows Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/adb_profile_chrome/controllers_unittest.py

diff --git a/tools/android/adb_profile_chrome/controllers_unittest.py b/tools/android/adb_profile_chrome/controllers_unittest.py

index 6702c389492ba8febaa973eb62ab26aca575ec93..5df7bea3aafd6a48194fca39e0d431a3c84fbb10 100644

--- a/tools/android/adb_profile_chrome/controllers_unittest.py

+++ b/tools/android/adb_profile_chrome/controllers_unittest.py

@@ -17,7 +17,7 @@ class BaseControllerTest(unittest.TestCase):

self.package_info = profiler.GetSupportedBrowsers()[self.browser]

self.device = device_utils.DeviceUtils(devices[0])

- adb = android_commands.AndroidCommands(devices[0])

- adb.StartActivity(self.package_info.package,

- self.package_info.activity,

- wait_for_completion=True)

+ self.device.StartActivity(

+ intent.Intent(activity=self.package_info.activity,

+ package=self.package_info.package),

+ blocking=True)

« no previous file with comments | « tools/android/adb_profile_chrome/chrome_controller.py ('k') | tools/android/mempressure.py » ('j') | no next file with comments »