build/android/tombstones.py - Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/tombstones.py

Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: appeasing windows Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/tombstones.py

diff --git a/build/android/tombstones.py b/build/android/tombstones.py

index 76dab15b2a7e3a95af46d52b8a298e78ac716789..1112a97c832441e857ed3890c14a0cbfa35da313 100755

--- a/build/android/tombstones.py

+++ b/build/android/tombstones.py

@@ -74,7 +74,7 @@ def _EraseTombstone(device, tombstone_file):

tombstone_file: the tombstone to delete.

"""

return device.RunShellCommand(

- 'rm /data/tombstones/' + tombstone_file, root=True)

+ 'rm /data/tombstones/' + tombstone_file, as_root=True)

def _ResolveSymbols(tombstone_data, include_stack):

« no previous file with comments | « build/android/pylib/uiautomator/test_runner.py ('k') | tools/android/adb_profile_chrome/chrome_controller.py » ('j') | no next file with comments »