build/android/pylib/flag_changer.py - Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/flag_changer.py

Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: appeasing windows Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/flag_changer.py

diff --git a/build/android/pylib/flag_changer.py b/build/android/pylib/flag_changer.py

index 9ccdc1eb7ea1befea1c358aacdacc8ff8fb45c34..c1ce16a5e1e53120f926716ea7e72e478c656292 100644

--- a/build/android/pylib/flag_changer.py

+++ b/build/android/pylib/flag_changer.py

@@ -114,7 +114,8 @@ class FlagChanger(object):

assert len(file_contents) == 1 and file_contents[0] == cmd_line, (

'Failed to set the command line file at %s' % self._cmdline_file)

else:

- self._device.RunShellCommand('rm ' + self._cmdline_file, root=use_root)

+ self._device.RunShellCommand('rm ' + self._cmdline_file,

+ as_root=use_root)

assert (

not self._device.old_interface.FileExistsOnDevice(

self._cmdline_file)), (

« no previous file with comments | « build/android/pylib/device/intent.py ('k') | build/android/pylib/forwarder.py » ('j') | no next file with comments »