Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: build/android/pylib/forwarder.py

Issue 338353004: [Android] Switch KillAll, StartActivity, and BroadcastIntent to DeviceUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # pylint: disable=W0212 5 # pylint: disable=W0212
6 6
7 import fcntl 7 import fcntl
8 import logging 8 import logging
9 import os 9 import os
10 import psutil 10 import psutil
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 333
334 cmd = '%s %s --kill-server' % (tool.GetUtilWrapper(), 334 cmd = '%s %s --kill-server' % (tool.GetUtilWrapper(),
335 Forwarder._DEVICE_FORWARDER_PATH) 335 Forwarder._DEVICE_FORWARDER_PATH)
336 device.old_interface.GetAndroidToolStatusAndOutput( 336 device.old_interface.GetAndroidToolStatusAndOutput(
337 cmd, lib_path=Forwarder._DEVICE_FORWARDER_FOLDER) 337 cmd, lib_path=Forwarder._DEVICE_FORWARDER_FOLDER)
338 338
339 # TODO(pliard): Remove the following call to KillAllBlocking() when we are 339 # TODO(pliard): Remove the following call to KillAllBlocking() when we are
340 # sure that the old version of device_forwarder (not supporting 340 # sure that the old version of device_forwarder (not supporting
341 # 'kill-server') is not running on the bots anymore. 341 # 'kill-server') is not running on the bots anymore.
342 timeout_sec = 5 342 timeout_sec = 5
343 processes_killed = device.old_interface.KillAllBlocking( 343 processes_killed = device.KillAll(
344 'device_forwarder', timeout_sec) 344 'device_forwarder', blocking=True, timeout=timeout_sec)
345 if not processes_killed: 345 if not processes_killed:
346 pids = device.old_interface.ExtractPid('device_forwarder') 346 pids = device.old_interface.ExtractPid('device_forwarder')
347 if pids: 347 if pids:
348 raise Exception('Timed out while killing device_forwarder') 348 raise Exception('Timed out while killing device_forwarder')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698