DescriptionRevert of Change HungPluginTabHelper to listen for infobar changes through Observer style. (https://codereview.chromium.org/297293002/)
Reason for revert:
Caused a crash on Windows. See crbug.com/354380
Original issue's description:
> Change HungPluginTabHelper to listen for infobar changes through Observer style.
>
> Test plan:
>
> 1) out/Debug/chrome --no-sandbox --ppapi-flash-path=/opt/google/chrome/PepperFlash/libpepflashplayer.so --ppapi-flash-version=`grep -i version /opt/google/chrome/PepperFlash/manifest.json | awk '{print $2}' | awk -F"\"" '{print $2}'`
> 2) Go to a site that has flash, e.g., http://www.flash-game.net/
> 3) Open Task Manager, Shift+Esc
> 4) Search for "Plug-in: Shockwave Flash" in the list.
> 5) Select it and click on "End process" button.
> 6) Go to the website and observe the infobar.
>
> Another way to test it is:
>
> 1) Add an infinite loop into ppapi/examples/scripting/post_message.cc
> 2) Build ppapi_example_post_message
> 3) out/Debug/chrome --no-sandbox --register-pepper-plugins="/home/tfarina/chromium/src/out/Debug/lib/libppapi_example_post_message.so;application/x-ppapi-post-message-example" ppapi/examples/scripting/post_message.html
>
> BUG=354380
> TEST=see above
> R=pkasting@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277292
NOTRY=true
TBR=pkasting@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277804
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 8 (0 generated)
|