Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 338353003: Revert of Change HungPluginTabHelper to listen for infobar changes through Observer style. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, droger
Visibility:
Public.

Description

Revert of Change HungPluginTabHelper to listen for infobar changes through Observer style. (https://codereview.chromium.org/297293002/) Reason for revert: Caused a crash on Windows. See crbug.com/354380 Original issue's description: > Change HungPluginTabHelper to listen for infobar changes through Observer style. > > Test plan: > > 1) out/Debug/chrome --no-sandbox --ppapi-flash-path=/opt/google/chrome/PepperFlash/libpepflashplayer.so --ppapi-flash-version=`grep -i version /opt/google/chrome/PepperFlash/manifest.json | awk '{print $2}' | awk -F"\"" '{print $2}'` > 2) Go to a site that has flash, e.g., http://www.flash-game.net/ > 3) Open Task Manager, Shift+Esc > 4) Search for "Plug-in: Shockwave Flash" in the list. > 5) Select it and click on "End process" button. > 6) Go to the website and observe the infobar. > > Another way to test it is: > > 1) Add an infinite loop into ppapi/examples/scripting/post_message.cc > 2) Build ppapi_example_post_message > 3) out/Debug/chrome --no-sandbox --register-pepper-plugins="/home/tfarina/chromium/src/out/Debug/lib/libppapi_example_post_message.so;application/x-ppapi-post-message-example" ppapi/examples/scripting/post_message.html > > BUG=354380 > TEST=see above > R=pkasting@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277292 NOTRY=true TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M chrome/browser/ui/hung_plugin_tab_helper.h View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 5 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Created Revert of Change HungPluginTabHelper to listen for infobar changes through Observer style.
6 years, 6 months ago (2014-06-17 17:50:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/338353003/1
6 years, 6 months ago (2014-06-17 17:52:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 17:52:29 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 17:52:30 UTC) #4
Peter Kasting
LGTM
6 years, 6 months ago (2014-06-17 17:56:17 UTC) #5
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 6 months ago (2014-06-17 17:56:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/338353003/1
6 years, 6 months ago (2014-06-17 17:58:22 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 18:03:53 UTC) #8
Message was sent while issue was closed.
Change committed as 277804

Powered by Google App Engine
This is Rietveld 408576698