Issue 338353002: Module size is uint32_t on Windows. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(517)

My Issues | Starred Open | Closed | All

Issue 338353002: Module size is uint32_t on Windows. (Closed)

Created:
6 years, 6 months ago by grt (UTC plus 2)

Modified:
6 years, 6 months ago

Reviewers:
erikwright (departed), robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Module size is uint32_t on Windows. BUG=none R=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278004

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/install_verification/win/module_info.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

grt (UTC plus 2)

According to http://msdn.microsoft.com/en-us/gg463119.aspx and winnt.h, SizeOfImage is a DWORD for both 32-bit and 64-bit images, ...

6 years, 6 months ago (2014-06-17 14:17:39 UTC) #2

erikwright (departed)

On 2014/06/17 14:29:54, robertshield wrote: > LGTM > > This looks correct to me. LGTM

6 years, 6 months ago (2014-06-18 02:13:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/338353002/1

6 years, 6 months ago (2014-06-18 03:11:17 UTC) #6

Message was sent while issue was closed.

Change committed as 278004

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698