Issue 338343002: Revert 176303 "ThreadableWebSocketChannelClientWrapper don't nee..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338343002: Revert 176303 "ThreadableWebSocketChannelClientWrapper don't nee..." (Closed)

Created:
6 years, 6 months ago by haraken

Modified:
6 years, 6 months ago

Reviewers:
yhirano

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 176303 "ThreadableWebSocketChannelClientWrapper don't nee..." This broke browser_tests (WebSocket2): http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/8151 > ThreadableWebSocketChannelClientWrapper don't need suspend / resume code. > > As the WebSocket class handles suspend / resume, we can remove the suspend / > resume code from ThreadableWebSocketChannelClientWrapper. > > BUG=384238 > R=tyoshino > > Review URL: https://codereview.chromium.org/333223002 TBR=yhirano@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176310

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -18 lines)			Patch
M	trunk/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h	View	2 chunks	+23 lines, -2 lines	0 comments	Download
M	trunk/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp	View	2 chunks	+102 lines, -14 lines	0 comments	Download
M	trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp	View	3 chunks	+46 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r176310.